Skip to content

Support skipping downloadGeoFiles task#734

Closed
Goooler wants to merge 1 commit into
MetaCubeX:mainfrom
Goooler:support-skip-download-geo-files
Closed

Support skipping downloadGeoFiles task#734
Goooler wants to merge 1 commit into
MetaCubeX:mainfrom
Goooler:support-skip-download-geo-files

Conversation

@Goooler
Copy link
Copy Markdown

@Goooler Goooler commented May 12, 2026

Only if skip.downloadGeoFiles is true and the destination is empty.

Refs Goooler#123.

Only if `skip.downloadGeoFiles` is true and the destination is empty.
@wwqgtxx
Copy link
Copy Markdown

wwqgtxx commented May 12, 2026

Have you tried skipping the download process and whether the program crashes on the first launch because it can't find the file?

Comment thread app/build.gradle.kts
Comment on lines +64 to +66
properties.getProperty("skip.downloadGeoFiles").toBoolean() &&
geoFilesDownloadDir.exists() &&
geoFilesDownloadDir.listFiles().orEmpty().size == 3
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

并不会,这里加了检查,如果设置了标记位且目标路径不为空才会跳过。
方便本地做开发,每次下载这几个文件很耗时。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那你这个PR的标题和内容说明也不对呀

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你这实现的明明是当文件存在的时候才允许skipping

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得已经写得非常清楚了

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你这标题和说明里可以一点都没提到会判断本地文件是否存在

@Goooler Goooler closed this May 12, 2026
@Goooler Goooler deleted the support-skip-download-geo-files branch May 12, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants