fix: ledger fall back to blind signing when clear-sign fails#522
Open
dawnseeker8 wants to merge 2 commits intomainfrom
Open
fix: ledger fall back to blind signing when clear-sign fails#522dawnseeker8 wants to merge 2 commits intomainfrom
dawnseeker8 wants to merge 2 commits intomainfrom
Conversation
Mirror metamask-extension PR #41948: try clearSignTransaction first, then signTransaction(..., null) when resolution fails. Re-throw user rejection (0x6985) without fallback. Add @ledgerhq/hw-transport as a runtime dependency.
dawnseeker8
changed the title
Contributor
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
montelaidev
approved these changes
Apr 30, 2026
Contributor
montelaidev
left a comment
montelaidev
left a comment
There was a problem hiding this comment.
Looks good, didn't test because the logs is the same as the one on extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror metamask-extension PR #41948: try clearSignTransaction first, then signTransaction(..., null) when resolution fails. Re-throw user rejection (0x6985) without fallback. Add @ledgerhq/hw-transport as a runtime dependency.
Note
Cursor Bugbot is generating a summary for commit 5788aa3. Configure here.