Open
Conversation
In a previous commit, a change was made where NetworkController would no longer retry failed requests if it detected that the user was offline. The ultimate goal was to prevent `NetworkController:rpcEndpointChainDegraded` and `NetworkController:rpcEndpointChainUnavailable` from being published, because these events are used to report issues to Segment about networks that have become degraded or unavailable. Since then, we have discovered that the logic to detect whether user is offline or online is not exactly reliable, and it may be possible for NetworkController to get stuck in an offline state. If that were to happen, then if the user were experiencing intermittent connectivity issues, failed requests would never get retried until MetaMask was restarted. This is not good from a user experience. And anyway, we don't have to do this. We can continue to retry requests *and* prevent the degraded and/or unavailable events from getting published. This commit makes that happen.
Contributor
Author
|
@metamaskbot publish-previews |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1614749. Configure here.
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
In a previous commit, a change was made where NetworkController would no longer retry failed requests if it detected that the user was offline. The ultimate goal was to prevent
NetworkController:rpcEndpointChainDegradedandNetworkController:rpcEndpointChainUnavailablefrom being published, because these events are used to report issues to Segment about networks that have become degraded or unavailable.Since then, we have discovered that the logic to detect whether user is offline or online is not exactly reliable, and it may be possible for NetworkController to get stuck in an offline state. If that were to happen, then if the user were experiencing intermittent connectivity issues, failed requests would never get retried until MetaMask was restarted.
This is not good from a user experience. And anyway, we don't have to do this. We can continue to retry requests and prevent degraded and/or unavailable events from getting published. This commit updates the logic in
RpcServiceaccordingly.References
(Ongoing issue with Morpho; see Slack)
Checklist
Note
Medium Risk
Changes retry/circuit-breaker behavior for RPC requests when offline, which can affect request load and how network availability/degradation analytics events are emitted.
Overview
Restores retry behavior while offline.
RpcServiceno longer disablesretryFilterPolicywhenisOffline()is true, so transient failures still get retried even if offline detection is inaccurate.Suppresses offline telemetry-style callbacks instead. When offline,
RpcServicenow skips invokingonDegradedandonBreaklisteners (but still retries), and tests were updated to remove “no retry offline” assertions while keeping expectations thatNetworkController:*Unavailable/*Degradedevents are not published when offline.Adds a changelog entry documenting the fix and updates lint suppression counts.
Reviewed by Cursor Bugbot for commit 892d98e. Bugbot is set up for automated code reviews on this repo. Configure here.