Enable PR link validation in changelogs by default#8637
Draft
Conversation
- Pass `--prLinks` to `auto-changelog validate` by default to check that all changelog entries have associated PR links and that the list of PR links is formatted correctly. - Correct existing changelogs to satisfy the new validation changes.
mcmire
commented
Apr 29, 2026
| ### Changed | ||
|
|
||
| - **BREAKING:** Bump peer dependency `@metamask/keyring-controller` from `^18.0.0` to `^19.0.0` ([#4915](https://github.com/MetaMask/core/pull/4956)) | ||
| - **BREAKING:** Bump peer dependency `@metamask/keyring-controller` from `^18.0.0` to `^19.0.0` ([#4915](https://github.com/MetaMask/core/pull/4915)) |
Contributor
Author
There was a problem hiding this comment.
#4915 was a release that included keyring-controller.
| ### Changed | ||
|
|
||
| - **BREAKING:** Bump dependency and peer dependency on `@metamask/keyring-controller` to ^9.0.0 | ||
| - **BREAKING:** Bump dependency and peer dependency on `@metamask/keyring-controller` to ^9.0.0 ([#2052](https://github.com/MetaMask/core/pull/2052)) |
Contributor
Author
There was a problem hiding this comment.
This entry was missing a PR link.
#2052 was a release that included keyring-controller.
| - Bump dependency on `@metamask/utils` to ^8.1.0 ([#1639](https://github.com/MetaMask/core/pull/1639)) | ||
| - Bump dependency on `@metamask/base-controller` to ^3.2.3 | ||
| - Bump peer dependency on `@metamask/keyring-controller` to ^8.0.2 | ||
| - Bump dependency on `@metamask/base-controller` to ^3.2.3 ([#1747](https://github.com/MetaMask/core/pull/1747)) |
Contributor
Author
There was a problem hiding this comment.
#1747 was a release that included base-controller.
| ### Changed | ||
|
|
||
| - **BREAKING:** Bump peer dependency on `@metamask/keyring-controller` to ^8.0.0 | ||
| - **BREAKING:** Bump peer dependency on `@metamask/keyring-controller` to ^8.0.0 ([#1708](https://github.com/MetaMask/core/pull/1708)) |
Contributor
Author
There was a problem hiding this comment.
#1708 was a release that included keyring-controller.
| - Bump dependency on `@metamask/utils` to ^8.1.0 ([#1639](https://github.com/MetaMask/core/pull/1639)) | ||
| - Bump dependency on `@metamask/base-controller` to ^3.2.3 | ||
| - Bump dependency on `@metamask/controller-utils` to ^5.0.2 | ||
| - Bump dependency on `@metamask/base-controller` to ^3.2.3 ([#1747](https://github.com/MetaMask/core/pull/1747)) |
Contributor
Author
There was a problem hiding this comment.
#1747 was a release that included base-controller.
| - Bump dependency on `@metamask/base-controller` to ^3.2.3 | ||
| - Bump dependency on `@metamask/controller-utils` to ^5.0.2 | ||
| - Bump dependency and peer dependency on `@metamask/network-controller` to ^14.0.0 | ||
| - Bump dependency on `@metamask/base-controller` to ^3.2.3 ([#1747](https://github.com/MetaMask/core/pull/1747)) |
Contributor
Author
There was a problem hiding this comment.
Missing links to #1747 (a release that included these packages).
| - Bump dependency on `@metamask/base-controller` to ^3.2.1 | ||
| - Bump dependency on `@metamask/controller-utils` to ^4.3.2 | ||
| - Bump dependency and peer dependency on `@metamask/network-controller` to ^12.1.2 | ||
| - Bump dependency on `@metamask/base-controller` to ^3.2.1 ([#1634](https://github.com/MetaMask/core/pull/1634)) |
Contributor
Author
There was a problem hiding this comment.
Missing links to #1634 (a release that included these packages).
|
|
||
| - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](https://github.com/MetaMask/core/pull/7511)) | ||
| - **BREAKING:** Changed `wallet_requestExecutionPermissions` to comply with 7715 spec revisions. | ||
| - **BREAKING:** Changed `wallet_requestExecutionPermissions` to comply with 7715 spec revisions ([#7603](https://github.com/MetaMask/core/pull/7603)) |
| - Bump `@metamask/network-controller` from `^24.2.2` to `^24.3.0` ([#6883](https://github.com/MetaMask/core/pull/6883)) | ||
| - This package was migrated from `MetaMask/eth-json-rpc-middleware` to the | ||
| `MetaMask/core` monorepo. | ||
| - This package was migrated from `MetaMask/eth-json-rpc-middleware` to the `MetaMask/core` monorepo ([#6866](https://github.com/MetaMask/core/pull/6866)) |
| ### Changed | ||
|
|
||
| - Add missing ISC license information ([#24](https://github.com/MetaMask/eth-json-rpc-provider/pull/24)) | ||
| - Add missing ISC license information ([#1855](https://github.com/MetaMask/core/pull/1855)) |
Contributor
Author
There was a problem hiding this comment.
Hmm.... this is not right. We need to keep these original links. I guess we'll have to add a new option to auto-changelog to accommodate this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
--prLinkstoauto-changelog validateby default to check that all changelog entries have associated PR links and that the list of PR links is formatted correctly.References
--prLinkswas added toauto-changeloga while back, but it hasn't been enabled so far in this repo.Checklist