feat: asset-controller tempo adjustments before migration#8638
Open
feat: asset-controller tempo adjustments before migration#8638
Conversation
maxime-oe
had a problem deploying
to
default-branch
GitHub Actions
Failure
maxime-oe
force-pushed
the
feat/tempo-asset-controller-upgrade
branch
2 times, most recently
from
a8b2d27 to
3c5a04a
Compare
maxime-oe
force-pushed
the
feat/tempo-asset-controller-upgrade
branch
from
3c5a04a to
5d3fb3f
Compare
maxime-oe
force-pushed
the
feat/tempo-asset-controller-upgrade
branch
from
5d3fb3f to
d8ff44d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d8ff44d. Configure here.
| if (!shouldSkipNativeForCaipChainId(chainId)) { | ||
| // Build a single AssetFetchEntry[] for native + custom ERC-20s | ||
| assetsToFetch.push({ assetId: nativeAssetId, address: ZERO_ADDRESS }); | ||
| } |
There was a problem hiding this comment.
Error path reintroduces native token for skipped chains
Medium Severity
The happy path now correctly skips adding the native asset to assetsToFetch for Tempo chains via shouldSkipNativeForCaipChainId, but the catch block unconditionally writes nativeAssetId back into assetsBalance (with amount '0') and assetsInfo (with type: 'native'). When fetchBalancesForAssets fails on a Tempo chain (e.g., network error fetching custom ERC-20s), native token data is reintroduced into state despite being intentionally excluded. While #shouldHideNativeToken filters at display time, this leaks inconsistent data into controller state.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit d8ff44d. Configure here.
Contributor
Author
|
@metamaskbot preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes balance-fetch inputs and price-support mappings for specific chains; risk is limited in scope but could affect Tempo balance/price display and any code assuming a native entry is always fetched.
Overview
Adjusts Tempo chain handling so native assets are no longer treated as fetchable/priced tokens.
RpcDataSourcenow conditionally omits the nativegetEthBalancerequest for chains inCHAIN_IDS_WITH_NO_NATIVE_TOKEN(via newshouldSkipNativeForCaipChainIdhelper), andAssetsControlleruses the same helper when deciding whether to hide native tokens. Inassets-controllers, Tempo entries inSPOT_PRICES_SUPPORT_INFOare updated to indicate no native asset and the pseudo-native address mappings are removed.Reviewed by Cursor Bugbot for commit d8ff44d. Bugbot is set up for automated code reviews on this repo. Configure here.