feat(profile-sync-controller): add new performProfilePairing action and remove pairing side-effect from performSignIn#8642
Open
mathieuartu wants to merge 4 commits intomainfrom
Open
Conversation
mathieuartu
had a problem deploying
to
default-branch
GitHub Actions
Failure
mathieuartu
changed the title
performProfilePairing action and remove pairing side-effect from performSignIn
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 97a26b3. Configure here.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
https://consensyssoftware.atlassian.net/browse/MUL-1791
Client PRs:
Checklist
Note
Medium Risk
Touches authentication/pairing flow and persisted controller state; behavior changes (pairing no longer happens during
performSignIn) could affect clients relying on the previous side effect.Overview
Decouples SRP profile pairing from sign-in by removing the implicit
/profile/pairside effect fromAuthenticationController.performSignInand introducing a new public/messenger-exposedperformProfilePairingmethod to run pairing on-demand.performProfilePairingattempts pairing only when 2+ SRPs exist, propagates the returned canonical profile ID across cached SRP sessions, conditionally emitsAuthenticationController:profileSignInwhen the canonical changes or aliases are returned, and persists a new monotonichasPairedAtLeastOncestate flag (set only after a successful pairing). Tests and action-type exports/changelog are updated accordingly.Reviewed by Cursor Bugbot for commit ae9b6b3. Bugbot is set up for automated code reviews on this repo. Configure here.