Skip to content

fix: fix touchable issues in ScrollView#21466

Merged
sethkfman merged 2 commits into
MetaMask:fix/touchable-issues-margelofrom
margelo:fix/touchable-issues
Oct 22, 2025
Merged

fix: fix touchable issues in ScrollView#21466
sethkfman merged 2 commits into
MetaMask:fix/touchable-issues-margelofrom
margelo:fix/touchable-issues

Conversation

@Nodonisko

@Nodonisko Nodonisko commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Description

Ported patch from react/react-native#51835 to version 0.76.9

I also had to enable build from source for Android in order to make patch work, that will result in increased build time.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduces a React Native patch adding measureAsyncOnUI across Fabric/UIManager and switches app components to plain TouchableOpacity, while enabling Android builds to compile RN from source.

  • React Native (patched):
    • Add measureAsyncOnUI API across Fabric/UIManager (JS, iOS, Android, JNI) and expose via UIManagerBinding.
    • Update Pressability and ReactFabricHostComponent to use measureAsyncOnUI for view measurement.
  • Android Build:
    • Enable building react-native from source with Gradle dependency substitutions.
  • App Components:
    • Simplify touch handling in ButtonBase, ListItemMultiSelect, and ListItemSelect by removing react-native-gesture-handler tap wrappers and using RNTouchableOpacity directly.
  • Tooling:
    • Add Yarn patch/resolution for react-native@0.76.9 and update yarn.lock.

Written by Cursor Bugbot for commit da7a9a0. This will update automatically on new commits. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the base branch from main to fix/touchable-issues-margelo October 21, 2025 19:25
@sethkfman sethkfman marked this pull request as ready for review October 21, 2025 19:26
@sethkfman sethkfman requested review from a team as code owners October 21, 2025 19:26

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nodonisko Nodonisko force-pushed the fix/touchable-issues branch from f74cadc to da7a9a0 Compare October 22, 2025 10:24
@sethkfman sethkfman merged commit 39fb8dd into MetaMask:fix/touchable-issues-margelo Oct 22, 2025
4 of 5 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2025
@sethkfman sethkfman linked an issue Dec 5, 2025 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Scroll disabled in Uniswap network picker on Android devices

3 participants