Skip to content

Cherry-picking commits from main to release/8.0.0 for PR #31838#32070

Open
runway-github[bot] wants to merge 1 commit into
release/8.0.0from
runway-cherry-pick-8.0.0-1781865517
Open

Cherry-picking commits from main to release/8.0.0 for PR #31838#32070
runway-github[bot] wants to merge 1 commit into
release/8.0.0from
runway-cherry-pick-8.0.0-1781865517

Conversation

@runway-github

@runway-github runway-github Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

This pull request enhances the handling and display of unlimited token
approval transactions across the app. It introduces a new
isUnlimitedApproval property to the transaction display data, updates
the logic to detect and label unlimited approvals, and ensures that UI
components and tests reflect these changes. The update also includes
comprehensive unit tests for the new logic.

Unlimited Token Approval Detection and Display:

  • Added isUnlimitedApproval to the MultichainTransactionDisplayData
    interface and implemented logic in useMultichainTransactionDisplay to
    set this flag for token approval transactions with amounts above 1e15.
    The transaction title for approvals is also updated to include the token
    unit if available.

UI and Rendering Updates:

  • Updated MultichainTransactionDetailsSheet and
    MultichainTransactionListItem components to use the
    isUnlimitedApproval flag. When true, these components display
    "Unlimited " instead of the raw approval amount, ensuring clarity
    for the user.

Testing Improvements:

  • Added and updated tests for both the hook
    (useMultichainTransactionDisplay) and the UI components to verify
    correct detection and display of unlimited approvals, including edge
    cases and title formatting.

Dependency Update:

  • Bumped @metamask/tron-wallet-snap dependency version from 1.26.0
    to 1.27.0 in package.json.

Changelog

CHANGELOG entry: fixed display approved transactions for Non-EVM
networks

Related issues

Fixes: Big number digit approved Non-EVM transactions break the display

Manual testing steps

Go to a TRON explorer dApp like Tronscan.

Makes an approved transaction on a TRC20 tokens like USDT with more than 15 digits

The approved transaction displays the Unlimited USDT label

Makes an approved transaction on a TRC20 tokens like USDT with less than 15 digits

The approved transaction display the approved amount of USDT

Screenshots/Recordings

Before

BEFORE-MOBILE-APPROVE-USDT

After

AFTER-MOBILE-APPROVE-USDT

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Display-only changes to multichain transaction formatting with new
unit tests; no auth, signing, or transaction execution logic is
modified.

Overview
Fixes broken transaction UI when non-EVM (e.g. TRON TRC20) approvals
carry very large allowance values by treating fungible TokenApprove
amounts above 10^15 as unlimited, consistent with the existing EVM
threshold.

useMultichainTransactionDisplay now exposes
isUnlimitedApproval, sets approve titles to
transactions.tx_review_approve plus the token unit when available,
and only flags unlimited for TokenApprove (not send/receive).

MultichainTransactionListItem and
MultichainTransactionDetailsSheet use that flag to render
confirm.unlimited plus the token symbol instead of the raw numeric
string; bounded approvals still show the formatted amount (including
when to is empty but from has the movement).

Adds unit tests for the hook and UI; bumps
@metamask/tron-wallet-snap to 1.27.0.

Reviewed by Cursor Bugbot for commit
42df571. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[19d69fc](https://github.com/MetaMask/metamask-mobile/commit/19d69fcfbcadac11c138874f32f6825add37c5d5)

…rks (#31838)

<!--
mms-check directive vocabulary — read by
.github/scripts/shared/pr-template-checks.ts
at module load to build the validation plan. Directives are invisible in
rendered
markdown and must NOT be removed or edited without updating the
validator registry.

  type=text           Section must contain non-placeholder prose.
  type=changelog      Section must have a valid CHANGELOG entry: line.
type=issue-link Section must have a Fixes:/Closes:/Refs: line with a
value.
type=manual-testing Section must have real testing steps or an explicit
N/A.
type=screenshot Section must have evidence (image/URL) or an explicit
N/A.
type=checklist Section must have all checkboxes consciously checked.
required=true|false Whether a missing/invalid section runs the validator
at all.
blocking=true|false Whether a failure of this check fails the CI
workflow.
Default: false — failures are shown as warnings in the sticky
                      comment but do not block the PR.

Sections without a directive are checked for structural presence only.
-->

## **Description**

<!-- mms-check: type=text required=true -->

This pull request enhances the handling and display of unlimited token
approval transactions across the app. It introduces a new
`isUnlimitedApproval` property to the transaction display data, updates
the logic to detect and label unlimited approvals, and ensures that UI
components and tests reflect these changes. The update also includes
comprehensive unit tests for the new logic.

**Unlimited Token Approval Detection and Display:**

* Added `isUnlimitedApproval` to the `MultichainTransactionDisplayData`
interface and implemented logic in `useMultichainTransactionDisplay` to
set this flag for token approval transactions with amounts above 1e15.
The transaction title for approvals is also updated to include the token
unit if available.

**UI and Rendering Updates:**

* Updated `MultichainTransactionDetailsSheet` and
`MultichainTransactionListItem` components to use the
`isUnlimitedApproval` flag. When true, these components display
"Unlimited <Token>" instead of the raw approval amount, ensuring clarity
for the user.

**Testing Improvements:**

* Added and updated tests for both the hook
(`useMultichainTransactionDisplay`) and the UI components to verify
correct detection and display of unlimited approvals, including edge
cases and title formatting.

**Dependency Update:**

* Bumped `@metamask/tron-wallet-snap` dependency version from `1.26.0`
to `1.27.0` in `package.json`.

## **Changelog**

<!-- mms-check: type=changelog required=true blocking=true -->

CHANGELOG entry: fixed display approved transactions for Non-EVM
networks

## **Related issues**

<!-- mms-check: type=issue-link required=true -->

Fixes: Big number digit approved Non-EVM transactions break the display

## **Manual testing steps**

<!-- mms-check: type=manual-testing required=true -->

```gherkin
Go to a TRON explorer dApp like Tronscan.

Makes an approved transaction on a TRC20 tokens like USDT with more than 15 digits

The approved transaction displays the Unlimited USDT label

Makes an approved transaction on a TRC20 tokens like USDT with less than 15 digits

The approved transaction display the approved amount of USDT
```

## **Screenshots/Recordings**

<!-- mms-check: type=screenshot required=true -->

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->
<img width="400" height="700" alt="BEFORE-MOBILE-APPROVE-USDT"
src="https://github.com/user-attachments/assets/f69e32f2-0be3-43ff-8c90-ce5ce310744e"
/>



### **After**

<img width="400" height="750" alt="AFTER-MOBILE-APPROVE-USDT"
src="https://github.com/user-attachments/assets/0a678dc8-8926-43cc-a945-070d86905c59"
/>


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!-- mms-check: type=checklist required=true -->

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Display-only changes to multichain transaction formatting with new
unit tests; no auth, signing, or transaction execution logic is
modified.
> 
> **Overview**
> Fixes broken transaction UI when non-EVM (e.g. TRON TRC20) approvals
carry very large allowance values by treating fungible **TokenApprove**
amounts above **10^15** as unlimited, consistent with the existing EVM
threshold.
> 
> **`useMultichainTransactionDisplay`** now exposes
**`isUnlimitedApproval`**, sets approve titles to
**`transactions.tx_review_approve`** plus the token unit when available,
and only flags unlimited for **TokenApprove** (not send/receive).
> 
> **`MultichainTransactionListItem`** and
**`MultichainTransactionDetailsSheet`** use that flag to render
**`confirm.unlimited`** plus the token symbol instead of the raw numeric
string; bounded approvals still show the formatted amount (including
when **`to`** is empty but **`from`** has the movement).
> 
> Adds unit tests for the hook and UI; bumps
**`@metamask/tron-wallet-snap`** to **1.27.0**.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
42df571. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner June 19, 2026 10:38
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jun 19, 2026
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​tron-wallet-snap@​1.26.0 ⏵ 1.27.010010096100 +1100

View full report

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@github-actions github-actions Bot added size-M risk:low AI analysis: low risk labels Jun 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low AI analysis: low risk size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant