Cherry-picking commits from main to release/8.0.0 for PR #31885#32071
Open
runway-github[bot] wants to merge 1 commit into
Open
Cherry-picking commits from main to release/8.0.0 for PR #31885#32071runway-github[bot] wants to merge 1 commit into
runway-github[bot] wants to merge 1 commit into
Conversation
## **Description** Adds development-gated fiat QA options for the MetaMask Pay fiat submit path. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** N/A ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - [ ] I've tested with a power user scenario - [ ] I've instrumented key operations with Sentry traces for production performance metrics For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes the fiat confirmation submit path and controller wiring, but behavior is limited to dev/rc/flask via env gating; misconfiguration in those builds could skip real on-ramp flows. > > **Overview** > Adds **dev/rc/flask-only** env-driven fiat QA hooks for MetaMask Pay: `getTransactionPayFiatTestOptions()` reads `TRANSACTION_PAY_FIAT_TEST_FUNDING_SOURCE` and `TRANSACTION_PAY_FIAT_TEST_AMOUNT_OVERRIDE` and returns nothing on production **main** builds. > > Those options are passed into **`TransactionPayController`** as `fiatOptions`, and **`TransactionPayController:getFiatOptions`** is delegated on the transaction-controller init messenger. > > On fiat confirm, when **`testFundingSource`** is set, **`useFiatConfirm`** no longer calls headless buy; it clears errors, keeps headless buy idle, and writes a synthetic **`orderId`** (`fiat-test-funding-source`) via `updateFiatPayment` when transaction metadata exists. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 0f0d891. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adds development-gated fiat QA options for the MetaMask Pay fiat submit
path.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
performance metrics
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Changes the fiat confirmation submit path and controller wiring, but
behavior is limited to dev/rc/flask via env gating; misconfiguration in
those builds could skip real on-ramp flows.
Overview
Adds dev/rc/flask-only env-driven fiat QA hooks for MetaMask Pay:
getTransactionPayFiatTestOptions()readsTRANSACTION_PAY_FIAT_TEST_FUNDING_SOURCEandTRANSACTION_PAY_FIAT_TEST_AMOUNT_OVERRIDEand returns nothing onproduction main builds.
Those options are passed into
TransactionPayControllerasfiatOptions, andTransactionPayController:getFiatOptionsisdelegated on the transaction-controller init messenger.
On fiat confirm, when
testFundingSourceis set,useFiatConfirmno longer calls headless buy; it clears errors,keeps headless buy idle, and writes a synthetic
orderId(
fiat-test-funding-source) viaupdateFiatPaymentwhen transactionmetadata exists.
Reviewed by Cursor Bugbot for commit
0f0d891. Bugbot is set up for automated
code reviews on this repo. Configure
here.