Cherry-picking commits from main to release/8.0.0 for PR #32037

[runway-github]

• feat: MUSD-1026 added remotely configurable vault APY fallback and override cp-8.0.0 (feat: MUSD-1026 added remotely configurable vault APY fallback and override cp-8.0.0 #32037)

Description

The APY in the Money account was previously hardcoded in __DEV__
blocks — a temporary workaround for the vault returning 0%. This
replaces that with a proper remote-config-driven solution via a new
earnMoneyVaultApyControl feature flag.

Two knobs are exposed:

• vaultApyFallback — shown only when the APY service returns
  undefined (e.g. third-party outage). Lets us set a sensible display
  value without overriding a live rate.
• vaultApyOverride — always shown instead of the service value
  when set. Useful for scheduled maintenance or launch-window display
  control.

Precedence: vaultApyOverride > live serviceApy > vaultApyFallback

undefined.

Changelog

CHANGELOG entry: added remotely configurable Money vault APY control

Related issues

• Fixes:
  MUSD-1026

Manual testing steps

Feature: Remote APY control for Money account

  Scenario: APY fallback shown when service is unavailable
    Given earnMoneyVaultApyControl.vaultApyFallback = 0.04 in remote config
    And the vault APY service returns no data
    When user opens the Money account screen
    And remote feature flags fetch successfully
    Then the displayed APY is 4%

  Scenario: APY override always wins over live service value
    Given earnMoneyVaultApyControl.vaultApyOverride = 0.08 in remote config
    And the vault APY service returns 5%
    When user opens the Money account screen
    And remote feature flags fetch successfully
    Then the displayed APY is 8%

  Scenario: Live service APY shown when no override configured
    Given earnMoneyVaultApyControl has no vaultApyOverride
    And the vault APY service returns 5%
    When user opens the Money account screen
    Then the displayed APY is 5%

Screenshots/Recordings

Before

N/A — no UI layout changes; only the data source for the APY value
changes.

After

N/A — no UI layout changes; only the data source for the APY value
changes.

Pre-merge author checklist

• I've followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format
  if applicable
• I've applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
• Use these power-user
  SRPs
  to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production
  performance metrics
• See trace() for usage and
  addToken
  for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots.

---

Note

Medium Risk
Displayed APY can diverge from the live vault service when override or
fallback is set; behavior is intentional but affects user-facing yield
messaging.

Overview
Replaces the temporary __DEV__ hardcoded 4% APY in
useMoneyAccountBalance with remote feature flag
earnMoneyVaultApyControl, exposing vaultApyFallback and
vaultApyOverride via selectMoneyVaultApyRemoteConfig.

Effective APY is now: override (when set) → live vault service →
fallback (only after the APY query settles or errors, not while loading,
to avoid flicker). Real 0% from the service is preserved when no
override is set.

Adds parseNonNegativeFinite and reuses it for
selectMoneyDepositMinBalance so negative remote/env values are
rejected. Registers the new flag in the feature-flag registry with
production defaults.

^{Reviewed by Cursor Bugbot for commit
1a4d182. Bugbot is set up for automated
code reviews on this repo. Configure
here.}

[b235142](https://github.com/MetaMask/metamask-mobile/commit/b23514281fb9720af11f9a96a8f16ca603c2672c)

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud