Cherry-picking commits from main to release/8.0.0 for PR #32096

[runway-github]

• fix(money): transaction details fee section incorrectly showing paid by metamask cp-8.0.0 (fix(money): transaction details fee section incorrectly showing paid by metamask cp-8.0.0 #32096)

Description

Fixes a bug where the "Paid by MetaMask" label was incorrectly shown on
the transaction details fee section for Money Account deposits that had
a non-zero bridge/service fee.

The isSponsored condition in TransactionDetailsFeeSection only
checked whether the network (gas) fee was zero, ignoring the bridge fee
entirely. This caused the fee section to collapse into a single "Paid by
MetaMask" row even when the user was still charged a bridge fee (e.g.
$0.89), hiding the real cost while the Total row still reflected it.

The fix aligns the activity view with the confirmation screen's contract
(useIsPaidByMetaMask): the unified "Paid by MetaMask" row now only
renders when both the network fee and the bridge fee are zero. When
gas is sponsored but a bridge fee is charged, the individual fee rows
render with their real amounts instead.

Changelog

CHANGELOG entry: Fixed a bug where "Paid by MetaMask" was incorrectly
displayed on transaction details when a bridge fee was still charged

Related issues

Fixes: Follow-up to #31908

Manual testing steps

Feature: Transaction Details Fee Section - Paid by MetaMask

  Scenario: Fully sponsored deposit shows "Paid by MetaMask"
    Given I have completed a Money Account deposit where both network and bridge fees are zero
    When I view the transaction details from the Money Account activity list
    Then I see a single "Transaction fees" row showing "Paid by MetaMask" with a green checkmark

  Scenario: Partially sponsored deposit shows individual fee rows
    Given I have completed a Convert Crypto deposit where gas was sponsored but a bridge fee was charged
    When I view the transaction details from the Money Account activity list
    Then I see a "Network fee" row showing "$0.00"
    And I see a "Bridge fee" row showing the actual bridge fee amount (e.g. "$0.89")
    And I do NOT see "Paid by MetaMask"
    And the "Total" row correctly reflects the deposit amount plus the bridge fee

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor
  Docs and MetaMask Mobile
  Coding
  Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format
  if applicable
• I've applied the right labels on the PR (see labeling
  guidelines).
  Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
• Use these power-user
  SRPs
  to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production
  performance metrics
• See trace() for usage and
  addToken
  for an example

For performance guidelines and tooling, see the Performance
Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the
  app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described
  in the ticket it closes and includes the necessary testing evidence such
  as recordings and or screenshots. 20fd0e1

[github-actions]

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud