Correct eleven gold annotations pointing at dead, shim, or deprecated files - #259
Open
Hartistic wants to merge 1 commit into
Open
Correct eleven gold annotations pointing at dead, shim, or deprecated files#259Hartistic wants to merge 1 commit into
Hartistic wants to merge 1 commit into
Conversation
…shim, or deprecated files Follow-up to MinishLab#257. Per query: - model2vec vocabulary-pruning: distill/utils.py (device selection only) -> tokenizer/tokenizer.py, where prune_added_tokens() lives. - model2vec tokenizer-construction: drop distill/utils.py from secondary. - pydantic validators: class_validators.py (5-line V1 migration shim) -> deprecated/class_validators.py, the actual V1-style validators. - aiohttp WebSocket client: _websocket/reader.py (31-line C/Py import switch) -> _websocket/reader_py.py, the implementation it re-exports. - zod (6 queries): v4/core/api.ts factories with zero call sites -> v4/core/schemas.ts (runtime classes) primary, v4/classic/schemas.ts (live builders) secondary. - vitest reporter interface: public/reporters.ts (deprecated re-export barrel since Vitest 4.1) -> node/types/reporter.ts primary, node/reporters/index.ts secondary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Confidence Score: 5/5The PR appears safe to merge; no concrete incorrect target, malformed annotation, or benchmark-contract violation was identified. The changed files retain the expected annotation structure, and the new targets align with the substantive implementations or definitions described by each query without an established scoring failure. Reviews (1): Last reviewed commit: "fix(benchmarks): correct eleven gold ann..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #257 — the corrections offered there, folded into one PR.
The benchmark scores a tool by whether it finds one specific "right answer" file for each question. For these eleven questions, the file the answer key names isn't where the behavior in the question actually lives: some of the named files hold copies of code nothing in the project calls anymore, some are small forwarding files that only point at the real implementation, and one is an entry point the project itself now warns against using. A tool that returns the genuinely useful file gets marked wrong on these; one that returns the leftover gets full credit. Each replacement below was checked by hand at the revisions pinned in
repos.json(call-site checks and file reads — the per-line evidence is in the issue thread).distill/utils.py(device selection only)tokenizer/tokenizer.py, whereprune_added_tokens()lives (secondarydistill/distillation.pyunchanged)distill/utils.pyclass_validators.py(5-line migration shim)deprecated/class_validators.py, the actual V1-style validators_websocket/reader.py(31-line C/Python import switch)_websocket/reader_py.py, the implementation it re-exportspublic/reporters.ts(re-export barrel, deprecated at runtime since Vitest 4.1)node/types/reporter.ts(theReporterinterface itself), secondarynode/reporters/index.tsThe six zod queries (union/discriminatedUnion, optional/nullable, transform/pipe, record/map, ZodDefault/ZodCatch, enum/nativeEnum/literal) all share one pattern:
v4/core/api.tsexports factory helpers thatclassic/andmini/reimplement rather than call — 49 of its 114 exported functions have no call site anywhere in the repo. Each of the six now points atv4/core/schemas.ts(the runtime classes that do the work) as primary, withv4/classic/schemas.ts(the builders users actually reach throughz.*) as secondary.Reran semble itself on the five affected repos before and after, same machine, scored the same way as the head-to-head in the issue:
Net positive for semble itself, mostly from zod — pointing the golds at files that actually contain the queried behavior makes them more findable for everyone. I didn't rerun the other models in the published table (as you said, they're the expensive part), so their columns will drift a little on these repos whenever they are.
🤖 Generated with Claude Code