Skip to content

Ajout des attributs type et position dans game.php et modification de… #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MisterSCO wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ajout des attributs type et position dans game.php et modification de… #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@
function displayPlayers(array $players) : void
{
foreach ($players as $player) {
echo $player['name'] . ': [H: ' . $player['health'] . '] [S: ' . $player['strength'] . ']';
if (array_key_exists('magic', $player)) {
echo '[M: ' . $player['magic'] . ']';
echo $player['name'] . PHP_EOL .
'Classe : ' .$player['type']['classe'] .PHP_EOL.
'Stats : [H: ' . $player['type']['health'] . '][S: ' . $player['type']['strength'] . ']';
if (array_key_exists('magic', $player['type'])) {
echo '[M: ' . $player['type']['magic'] . ']';
}
echo PHP_EOL;
echo PHP_EOL .'Position : ['. $player['position']['x'] .';'. $player['position']['y'].']' . PHP_EOL . PHP_EOL;
}
}

Expand All @@ -38,7 +40,6 @@ function displayBoard(array $board) : void
echo '[' . $x . ',' . $y . '] ';
}
}
echo PHP_EOL;
echo PHP_EOL;
echo PHP_EOL . PHP_EOL;
}
}
66 changes: 43 additions & 23 deletions game.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@
define('SIZE_X', 10);
define('SIZE_Y', 10);

define('WARRIOR', array(
'classe' => 'Warrior',
'health' => '100',
'strength' => '50') );
Comment on lines +10 to +13

@F2000-FR F2000-FR Feb 16, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm ! Intéressant ! Je n'avais pas pensé à une solution de ce type qui pourrait être envisageable si on considérait que les valeurs "force", "santé", "mana" soient fixes pour chaque type de personnage (guerrier, magicien).
Là, on souhaiterait pouvoir garder des données variables. Donc ne pas changer autant de choses dans le code finalement.

Juste garder les constantes WARRIOR, WIZARD, STEALTH (THIEF?) en variable simple (= valeur numérique par ex : 1/2/3).

Après, on aura pu garder une partie de votre logique, en ayant des clés de tableaux comme :

min_health
max_health
min_strength
max_strength
...
cela aurait pu permettre de préparer une génération automatique des caractéristiques du personnage en fonction de leur classe tout en gardant certaines "bornes" logiques (ex: un guerrier est souvent plus fort qu'un magicien, etc.)

Mais restons simple pour le moment ;)


define('WIZZARD', array(

@F2000-FR F2000-FR Feb 16, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attention un seul 'Z' !

'classe' => 'Wizzard',
'health' => '80',
'strength' => '50',
'magic' => '200'));



echo '============== Début du programme =============='.PHP_EOL;
Expand All @@ -28,54 +39,63 @@

$hercule = [
'name' => 'Hercule',
'health' => '100',
'strength' => '50'
'type' => WARRIOR,
'position' => array(
'y' => 0,
'x' => 0,
)
];

$merlin = [
'name' => 'Merlin',
'health' => '80',
'strength' => '50',
'magic' => '200'
'type' => WIZZARD,
'position' => array(
'y' => 0,
'x' => 1,
Comment on lines +53 to +54

@F2000-FR F2000-FR Feb 16, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On pourrait réutiliser rand ( ) pour rajouter un peu d'aléatoire mais une bonne idée d'avoir deux clés "x" et "y" 👍

)
];

$amaterasu = [
'name' => 'Amaterasu',
'health' => '90',
'strength' => '40',
'type' => WARRIOR,
'position' => array(
'y' => 0,
'x' => 2,
)
];

$zeus = [
'name' => 'Zeus',
'health' => '60',
'strength' => '20',
'magic' => '230'
];

$sobek = [
'name' => 'Sobek',
'health' => '200',
'strength' => '10',
'magic' => '20'
'type' => WIZZARD,
'position' => array(
'y' => 0,
'x' => 3,
)
];


$characters = [
$hercule,
$merlin,
$amaterasu,
$zeus,
$sobek
$zeus
];




//3. Positionner (aléatoirement) nos joueurs dans le plateau
// ex: $board[0][0] = $merlin

foreach ($characters as $character) {
$board[rand(0, 4)][rand(0, 4)] = $character;
/* $y = rand(0,(SIZE_Y - 1));
$x = rand(0,(SIZE_X - 1)); */

$y = $character['position']['y'];
$x = $character['position']['x'];

$board[$y][$x] = $character;
echo '['. $x .'/' . $y .']'. $character['name']. PHP_EOL;
}

//4. Afficher le plateau de jeu proprement
Expand Down