fix: validate complete output hex and string user IDs - #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject malformed output keys and masks before hex decoding, including a valid 32-byte prefix followed by an odd nibble or non-hex suffix. Preserve uppercase hex and the default mask behavior.
Require decimal-string user IDs at runtime so JavaScript numbers cannot silently encode an already-rounded ID.
Addresses the two input-validation review findings in #509. Adds regression coverage for invalid inputs and preserved valid behavior.
Validation: 187 tests passed; 16 integration tests skipped. Lint and TypeScript checks passed.