Skip to content

fix: add missing Popover import in DetailHeader #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JasonW404 merged 3 commits into from
Apr 29, 2026
+5 −5
Merged

fix: add missing Popover import in DetailHeader #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee11ed
fix: add missing Popover import in DetailHeader
Apr 29, 2026
2a5074f
merge: merge main into fix/detailheader-popover-import
Apr 29, 2026
7800a5a
fix: correct Tag id type from number to string (UUID)
Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/AddTagPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useEffect, useMemo, useState } from "react";
import { useTranslation } from "react-i18next";

interface Tag {
id: number;
id: string;
name: string;
color: string;
}
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/components/DetailHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useLayoutEffect, useEffect, useRef, useState, useCallback, useMemo } from "react";
import { Database } from "lucide-react";
import { Card, Button, Tag, Tooltip, Modal } from "antd";
import { Card, Button, Tag, Tooltip, Modal, Popover } from "antd";
import type { ItemType } from "antd/es/menu/interface";
import AddTagPopover from "./AddTagPopover";
import ActionDropdown from "./ActionDropdown";
Expand Down Expand Up @@ -32,9 +32,9 @@ interface OperationItem {

interface TagConfig {
showAdd: boolean;
tags: Array<{ id: number; name: string; color: string } | string>;
tags: Array<{ id: string; name: string; color: string } | string>;
onFetchTags?: () => Promise<{
data: { id: number; name: string; color: string }[];
data: { id: string; name: string; color: string }[];
}>;
onAddTag?: (tag: string) => void;
onCreateAndTag?: (tagName: string) => void;
Expand All @@ -48,7 +48,7 @@ interface DetailHeaderProps<T> {
}

// 标签单行渲染组件
const TagsInline = ({ tags }: { tags: Array<{ id: number; name: string; color: string } | string> }) => {
const TagsInline = ({ tags }: { tags: Array<{ id: string; name: string; color: string } | string> }) => {
const containerRef = useRef<HTMLDivElement>(null);
const tagsAreaRef = useRef<HTMLDivElement>(null);
const [visibleTags, setVisibleTags] = useState<typeof tags>([]);
Expand Down
Loading