fix(session): recover concatenated session index records#2074
Draft
shizhigu wants to merge 2 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 490fb8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shizhigu
force-pushed
the
agent/fix-corrupt-session-index
branch
from
July 22, 2026 17:57
18fcf1a to
490fb8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1925
Problem
When two records in
session_index.jsonllose the newline between them, the reader sends the combined line toJSON.parseand drops both records.SessionStore.getthen returnssession.not_foundeven when the session directory is intact.All current writers append a newline, so the write-side source is still unknown. This change limits recovery to the read path.
What changed
JSON.parsefast path. On failure, scan adjacent JSON containers while accounting for nested values, strings, and escapes.flowchart LR A["physical line"] --> B{"single-record parse"} B -->|valid| C["validate and apply"] B -->|invalid| D["scan adjacent containers"] D --> E["apply complete records in order"] D -->|damage| F["stop at first untrusted byte"]Here
AandBare complete JSON records:A\nBA,BABA,BA+ truncatedBAA+ garbage +BARecovery is read-only and does not rewrite or reindex the file.
Validation
git diff --check: passed.The original Windows write-side trigger was not reproduced. Tests use the missing-separator file shape from the issue.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.