fix(gip): spell the base branch as <default-branch> throughout - #1013
Conversation
PR #1008 parameterized the base branch across this file but left two prescriptive instances reading the literal `main`, so one file now gave the same instruction two ways. Deferred there rather than fixed, correctly: both lines were byte-identical to `main`, so editing them on that branch would have put it out of step. #1008 has since merged, which is the follow-up its own rule prescribes. Line 71 read `origin/main` where the surrounding steps prescribe `origin/<default-branch>`; line 40 named `main` as the base an issue branches from. Both now name the parameter. Left alone: the two occurrences that are evidence rather than instruction -- the sentence naming the literal string `main` as the thing not to hard-code, and the verbatim `fatal: invalid reference: origin/main` a reader will match against their own terminal. Line 71's em-dash became this diff's to fix once the line was edited, so it is now `--`.
2026-08-01 05:37 UTC |
<default-branch> throughout
Code reviewReviewed Verification performed:
No bugs, no CLAUDE.md/lab-manual violations, and no hallucinations found. This is a minimal, well-scoped, and thoroughly self-verified documentation fix. VerdictReady for merge |
|
Claude finished review — View run Posted the review comment successfully: #1013 (comment) SummaryReviewed PR #1013, a minimal fix to Verification performed:
No bugs, no CLAUDE.md/lab-manual violations, no hallucinations found. VerdictReady for merge |
|
Ready for merge, on All 10 check runs completed green at
Verified here rather than relayed from the review: Generated by Claude Code |
Closes the one item PR #1008 deliberately left behind:
skills/gip/SKILL.mdgave the same instruction two ways.
#1008 parameterized the base branch to
origin/<default-branch>throughout theworktree-isolation steps, and correctly Deferred the remaining literal
mainspellings rather than fixing them on that branch. They werebyte-identical to
mainat the time, so editing them there would have put thebranch out of step with
mainover content it did not own -- themain-syncrule in
address-every-comment.md, and the authorship-not-adjacency line indont-incur-technical-debt.md.That rule's stated follow-up is "fixing it on
maindirectly, not a newissue". #1008 merged as
3eb15a4, so that is now possible, and this is it.What changed
main<default-branch>origin/mainorigin/<default-branch>Line 71 also carried an em-dash. Editing a line makes its pre-existing
violations part of this diff, per
ascii-punctuation-in-source.md, so that oneis now
--. The file's other em-dashes are untouched, since a whole-filereplace is a different and much larger change than the finding asks for.
What was deliberately left alone
Two occurrences of
mainremain, and both are evidence rather thaninstruction:
main" as the thing notto hard-code. It is about the string, so substituting it erases the point.
fatal: invalid reference: origin/main. A readermatches that against their own terminal output, so a parameterized version
matches nothing.
The sweep was mechanical rather than by eye, because the recurrence had been
under-reported at earlier rounds: a word-boundary scan for
mainover thewhole file returned exactly four occurrences, and each was classified before
anything was edited. Four before, two after.
The general rule behind that split -- a consistency edit must stop at anything
asserting what was observed -- is recorded separately in #1014, which found it
unwritten anywhere in the corpus even though #1008 had applied it correctly.
Verification
\bmain\bsweep over the file: 4 occurrences before, 2 after,both remaining ones intended.
scripts/sync-codex-skill-wrappers.pyre-run: 175 wrappers regenerated, nodrift (
git statusclean afterward).git diff -U0 origin/main...HEAD(three-dot range,run after committing,
LC_ALL=C.UTF-8): 5 added lines examined, 0 hits, 0non-ASCII of any kind.
NLB_BASE_REF=origin/main check-new-line-breaks.py: "No lines missingsemantic breaks."
git ls-remote origin fix/gip-default-branch-spellingmatching
git rev-parse HEADatf368be4.Disjoint from #1014, which touches only
shared/fragments. No merge-orderconstraint between them; either can land first.
Generated by Claude Code