ums: hold a fallback self-review to the bot's prose-fact-check bar - #1094
Conversation
…loses #1093) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C9YWAmy9vJ7A6pEfkofgMk
Code reviewReviewed the diff (one new subsection added to One finding, posted inline on VerdictNeeds minor changes — one non-blocking-but-ironic citation fix (inline comment above); otherwise ready for merge. |
|
Claude finished review — View run Review posted. Summary: Finding (1, inline): Everything else checked out clean: both linked files exist, the cited case record (#1092/#1093) accurately reflects history, the Do/Don't block is properly labelled, punctuation/line-break conventions are followed, and the insertion doesn't duplicate nearby content or break any back-references. VerdictNeeds minor changes — one non-blocking citation fix flagged inline (with a suggested rewording); otherwise ready for merge. |
claude-review round 1 found the paragraph misattributed a 'citation' claim-type check to metacognitive-monitoring.md, which has exactly four claim types (State, Scope, Cause, unexamined default) and no citation type. The read-the-cited-source rule lives in address-every-comment.md. Fixed the main sentence and the parallel first Do bullet; the cause half stays pointed at metacognitive-monitoring. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C9YWAmy9vJ7A6pEfkofgMk
|
Claude finished review — View run Code review — #1094Scope checked: What changed since the last round: The PR added a new Verification of the fix: Commit
No new issues found in this round. VerdictReady for merge. |
Closes #1093.
What this records
Sharpens
CLAUDE.md's "Do the review yourself when the @claude workflow doesn't produce a verdict" section with a Do/Don't-labelled note about a specific trap: a fallback self-review -- one posted because the automated reviewer was unavailable (quota-skipped, stub, or erroring on an infra failure) -- feels like a stopgap and so tends to get a shallower pass than the round deserves. The gap is predictable: a shallow self-review checks structure (dogfood back-reference, ASCII, semantic line breaks) and skips the prose fact-check, so a false mechanism claim or a misattributed citation sails straight through.The fix: run the applicable prose-review skills against the diff's own factual claims --
fact-check-prose, the cause claim-type check inmetacognitive-monitoring, and the read-the-cited-source rule inaddress-every-comment-- not just the structural checks. The standard does not relax because the reviewer it replaces was absent.Case record
#1092, 2026-08-03: a fallback self-review posted while
claude-reviewwas erroring on infra failures reported "no findings / ready" and missed two content bugs the recovered bot then caught -- a false mechanism claim about a directional-word grep, and a citation misattributed toshared/writing/definition-crossrefs.md(which is about formal Quarto crossref-div ordering and says no such thing). Both are semantic errors escaping mechanical checks -- the very subject of the reviewed section.Placement / near-duplicate check
CLAUDE.md"Do the review yourself..." is the closest home; it already says "Apply the same review standards the bot would" but does not warn about fallback shallowness or name the prose fact-check skills. This is the fallback-specific sharpening of that line.shared/workflow/ardi.md's pre-push self-review section namesfact-check-prose, but for the general pre-push convention check, not the fallback-substitute case or its stopgap-shallowness trap.shared/workflow/fully-clean.mdcovers self-review-as-fallback but framed around "still need an external verdict when reachable", not the prose-fact-check bar for the fallback you post.shared/workflow/metacognitive-monitoring.mdsupplies the cause claim-type check the fix points at (its claim-type list is State/Scope/Cause/unexamined-default); the citation-checking rule lives inshared/workflow/address-every-comment.md, so the fix links both.stopgap,shallow,same bar as the bot,same review standardsfound no existing coverage of this trap.Collision note
Disjoint from the other open PRs. #1088 also touches
CLAUDE.mdbut at a distant section (~L521, the review-verdict-query section); this edit is at ~L887. The other open PRs (#1047hooks/, #1091/#1089/#1087shared/, #1092shared/writing/forward-references.md, #1042hooks/) do not touchCLAUDE.md.Self-checks
---used for dashes.**Bold.**+ next-sentence pattern matches the dominant corpus convention (the local reformatter's suggestion to merge them is the documented.**-boundary false-merge it makes on all 31 existing bold-lead entries too).definition-crossrefs.mdcharacterization in the case record was verified by reading the file.Review round 1 (addressed)
claude-reviewcorrectly caught that the paragraph itself misattributed a "citation" claim-type check tometacognitive-monitoring.md(which has no such type) -- the exact bug the paragraph warns about. Fixed in45fdb5c: the file's main sentence and first Do bullet now point the cited-source half ataddress-every-comment, and this PR body is synced to match.