ums(2071): gha SemBr check enforces rules the local script does not - #2095
Conversation
Banked from PR #2071: a section passed scripts/semantic-line-breaks.py and failed gha check-new-line-breaks on mid-line semicolons.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…es not" This reverts commit 4f55705.
|
All three findings addressed: reverted the memories/github-actions.md fork (which removes the violating line, the pronoun, and the duplication in one stroke) and appended the #2071 instance to shared/writing/semantic-line-breaks.md as a fourth dated recurrence cross-referencing #2085, per challenge-redundant-content. |
|
Claude finished review — View run Confirmed open, unmerged, not draft. Review complete. Code review — #2095Summary: This PR has been substantially revised since the last review round. The original commit (
New finding1. (Non-blocking, but a genuine factual error) "hours earlier" misstates the actual time gap, which was minutes. I checked the actual timestamps:
Every one of these events falls within a ~10-minute window (05:50Z–06:00Z), and even against the widest reasonable reference point (PR #2071's own creation at 05:13Z), the gap is under an hour — never "hours." Given this file's own stated purpose is precise, checkable dated-recurrence record-keeping (per VerdictReady for merge — the two blocking issues from the prior review round (CI-breaking line, redundant content) are both resolved through the author's revision, and the technical claims I independently checked (commit diffs, issue/PR cross-references, semicolon count) hold up. The one new finding ("hours earlier" vs. the actual ~10-minute gap) is a minor factual imprecision, not a blocker; recommend fixing it in this PR or a quick follow-up, but it shouldn't hold up the merge. Reviewed commit: 1555707 |
Closes nothing; banks the UMS learning from #2071. Follow-up issue for the tools.md split: #2093.
One new section in
memories/github-actions.md: the repo-localscripts/semantic-line-breaks.pyand the ghacheck-new-line-breaks.ymlenforce different rule sets (gha additionally flags long lines with mid-line semicolons), so a green local run does not predict the CI check. Pattern/anti-pattern pair included per corpus style.