ums: bank five process learnings from the 2026-08-24 session - #2171
Merged
Conversation
- github-actions.md: a SHA pin on a reusable workflow freezes the caller, not the refs it resolves at run time (ai-config#2165). - fact-check-code-logic.md: a misleading test label also licenses a deletion, the direction with no mutation available. - derive-dont-enumerate.md: the files already open are the weakest population; derive from history with git log -S/-G. - fixtures-are-not-evidence.md: an alternative no fixture can isolate may be dead rather than untested. - semantic-line-breaks.md: an ellipsis is a sentence boundary to the gate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Warning Claude review skipped — API credential or quota unavailable. No |
Collaborator
🤖 Fallback Self-Review (Adversarial)Head commit reviewed: \33173d56\ (branch \ums/session-2026-08-24-disclosure) Summary & Verification
VerdictVerdict: Clean / Ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UMS pass banking five transferable process learnings from a long 2026-08-24 session.
Seven candidates were considered; three were verified as already covered and are not duplicated (see the skip table below), per
grep-is-not-coverage.Entries written
memories/github-actions.mdshared/coding/fact-check-code-logic.mdshared/workflow/derive-dont-enumerate.mdshared/workflow/fixtures-are-not-evidence.mdshared/writing/semantic-line-breaks.mdVerification
Each claim was derived rather than recalled:
ai-config#2165is the fix; the delegation chain and the 340-vs-637-line split are recorded in this repo's own.github/workflows/validate.ymlcomment. The executed script was fetched at the pinned SHA and confirmed at 637 lines._SENT_BREAK_REwas run over four inputs at the pinned SHA:... " And,[...] Everything, andone. Twoeach split;... continuesdid not.files in front of,already open in,availability sampl,returns confirmationsreturned 0 hits acrossshared/andmemories/.Checks
origin/mainat the pinned SHA:No lines missing semantic breaks.scripts/check-links.py: 2306 links across 553 files, no breakage.scripts/check-context-closure.py: 8 fragments examined, 0 over the per-file cap. None of the five files is an@-import, so the always-loaded closure is unchanged.Deliberately not recorded
The disclosure rule and the claim wording themselves --- those ship in #2131.
Skipped as already covered
shared/writing/semantic-line-breaks.md--- already carries four dated recurrences, including 2026-08-24tool-mappings.mdis generated fromtool-mappings.ymlAGENTS.md, "Canonical sources vs generated output" tableshared/writing/fact-check-prose.md, with the same exclude-the-stating-file remedy