dialect: add slayer emit-only target - #1
Draft
yranchere wants to merge 1 commit into
Draft
Conversation
Emit one SLayer model YAML per table (SlayerModel schema v8, the shape `slayer models create` reads; github.com/MotleyAI/slayer). SLayer picks aggregations at query time, so the IR maps directly: measures become named `col:agg` formulas, derived metrics lower to SLayer's formula DSL, filtered aggregates become hidden columns carrying SLayer's aggregation-time `filter:`, unbounded cumulative windows emit as `cumsum(...)`, and a query table source lands in `sql:` (a query-backed model). Degrades loudly per the loss policy: role-playing dimensions (SLayer allows one join per target model), measure names colliding with a column (shared namespace) or shadowing a transform name, per-metric grains and slice-by restrictions, bounded windows, and conversion metrics all go to NOTES.md. Every emitted ecommerce golden validates against SLayer's own SlayerModel.model_validate and its formula parser. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
slayertarget dialect to semglot: any supported source (dbt,ossie) now transpiles into ready-to-import SLayer models — one SlayerModel v8 YAML per table, the exact shapeslayer models createreads.Mapping highlights
SLayer chooses aggregations at query time, so the IR maps with unusually high fidelity:
col:aggformulas (order_net_booked:sum)net_revenue / orders, bare refs to saved measures)filter:cumsum(...)sql:(query-backed model), a slot most targets lackmeta.synonyms(structured), enums fold into descriptionsDegrades (loud, per the loss policy)
_measurewith a noteVerification
SlayerModel.model_validateand itsparse_formula(with the model's measure library) — this caught the shared-namespace and one-join-per-target constraints during developmentNotes for reviewers
Parserfor slayer→IR would be the follow-up making it bidirectionalbenchouse/semglot🤖 Generated with Claude Code