release: pull v2.1.0 from the appcast - #95
Merged
Conversation
AttachToProcessViewController was a shared singleton, so every document presented the same instance. The second document to open Attach To Process rebinds a controller the first one is still presenting, and the app crashes. v2.1.0 and v2.1.0-RC.3 both ship that code. Follow the rollback runbook: the GitHub Release is already marked as a pre-release (latest is v2.0.1 again), and both 2.1.0 <item>s go away here so no client is offered the build. Sparkle never downgrades, so users already on 2.1.0 need the hotfix instead.
Contributor
There was a problem hiding this comment.
Pull request overview
Rolls back the Sparkle appcast to prevent clients from being offered the broken RuntimeViewer 2.1.0 / 2.1.0-RC.3 builds by removing those releases from the feed, making 2.0.1 the newest available update entry.
Changes:
- Removed the stable
2.1.0<item>from the appcast feed. - Removed the
beta-channel<item>pointing atv2.1.0-RC.3. - Left
2.0.1as the topmost available appcast entry.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AttachToProcessViewControllerwas held as a shared singleton behind@Dependency(\.attachToProcessViewController), so every open document presented the same controller instance. When a second document opens Attach To Process, it rebinds a controller the first document is still presenting, and the app crashes.Both
v2.1.0andv2.1.0-RC.3contain the offending commit (6849d78).What this does
Removes both
2.1.0<item>s fromdocs/appcast.xml— the stable one and thebeta-channel one that points atv2.1.0-RC.3. The feed now tops out at2.0.1, so no client is offered the broken build.Already done outside this PR, per
Documentations/SparkleRelease.md→ Rolling back a bad release:gh release edit v2.1.0 --prerelease— GitHub now servesv2.0.1as latest.Follow-up
Sparkle never downgrades, so users who already took
2.1.0stay on it. They need a2.1.1hotfix that makes the controller per-document.