Skip to content

fix(attach): give every document its own attach-to-process sheet #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mx-Iris merged 1 commit into from
Aug 12, 2026
Merged

fix(attach): give every document its own attach-to-process sheet #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ...erUsingAppKit/RuntimeViewerUsingAppKit/Attach Process/AttachToProcessViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import DependenciesMacros
final class AttachToProcessViewController: UXKitViewController<AttachToProcessViewModel> {

override var shouldDisplayCommonLoading: Bool { true }

fileprivate static let shared = AttachToProcessViewController()

private let pickerViewController: RunningPickerTabViewController

Expand Down Expand Up @@ -73,10 +71,3 @@ extension AttachToProcessViewController: RunningPickerTabViewController.Delegate
cancelRelay.accept()
}
}

// MARK: - Dependencies

extension DependencyValues {
@DependencyEntry(liveValue: MainActor.assumeIsolated { AttachToProcessViewController.shared })
var attachToProcessViewController: AttachToProcessViewController
}
3 changes: 1 addition & 2 deletions RuntimeViewerUsingAppKit/RuntimeViewerUsingAppKit/Main/MainCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import LateResponders
typealias MainTransition = SceneTransition<MainWindowController, MainSplitViewController>

final class MainCoordinator: SceneCoordinator<MainRoute, MainTransition>, LateResponderRegistering {
@Dependency(\.attachToProcessViewController) private var attachToProcessViewController

let documentState: DocumentState

Expand Down Expand Up @@ -86,7 +85,7 @@ final class MainCoordinator: SceneCoordinator<MainRoute, MainTransition>, LateRe
viewController.setupBindings(for: viewModel)
return .uxPopover(viewController, relativeTo: sender.bounds, of: sender, preferredEdge: .maxY, behavior: .transient, animates: true)
case .attachToProcess:
let viewController = attachToProcessViewController
let viewController = AttachToProcessViewController()
let viewModel = AttachToProcessViewModel(documentState: documentState, router: self)
viewController.setupBindings(for: viewModel)
viewController.preferredContentSize = .init(width: 800, height: 600)
Expand Down