sidebar is now resizeable - #438
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://witty-hill-08172a210-438.centralus.5.azurestaticapps.net |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 727117cc02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| window.addEventListener('mousemove', handleResizeMove) | ||
| window.addEventListener('mouseup', handleResizeEnd) |
There was a problem hiding this comment.
If the pointer leaves the browser window and the mouse button is released outside it, the registered mouseup handler never runs. This leaves isResizing enabled and the body's cursor and userSelect overrides active, so later mouse movement resizes the sidebar even without a button held. Handle window blur/pointer cancellation or use pointer capture so every drag has a guaranteed cleanup path.
Useful? React with 👍 / 👎.
Gonza10V
left a comment
Gonza10V
left a comment
There was a problem hiding this comment.
The code looks good to me, and the review from Codex is not reproducible. In my test the GUI worked as expected.
I would reduce the defaul size because you have to scrool to the right to find the collapse arrow
I would add a blue line when the side is being resized
review if there is a more effiecient wat to resize it
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://witty-hill-08172a210-438.centralus.5.azurestaticapps.net |
2 participants
No description provided.