Fix(#78): replaced internal function reference to external - #87
Open
andybeet wants to merge 2 commits into
Open
Conversation
andybeet
marked this pull request as ready for review
August 14, 2026 15:27
Member
Author
|
@MGrezlik. Your Rpath scripts that used |
Collaborator
|
@andybeet Thanks for the reminder. I'll put an issue in that repo. Once we work through all the clam survey issues in the survdat repo I will want to do a fresh pull for the Rpath models |
BBeltz1
approved these changes
Aug 14, 2026
BBeltz1
left a comment
Collaborator
There was a problem hiding this comment.
code looks good, local test run worked no issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
survdathad internal functions that were needed for data analysis outside of the package. These were made external functions in thesurvdatpackage. As a consequence all reference to them here needed to change from using:::to::. This PR makes these changesFixes #78
Types of changes
What types of changes does this pull request introduce? Put an
xin the boxes that apply.This will inform the new release number.
Reviewer instructions
Install
survdatv2.0.0.Running any one of the workflows that use
survdatshould be suffice,exp_n,shannon_survey, ormass_inshore_survey. For exampleSOEWorkflows::create_mass_inshore_survey(input_path_mass_survey, input_path_species). You can use theexample_test_runs.rscript as a template. Please don't commit additional example_test scripts, but keep them locally.Formatting
This repo contains an
air.tomlfile that automatically formats code to a set of standards.It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.