Skip to content

Fix(#78): replaced internal function reference to external - #87

Open
andybeet wants to merge 2 commits into
devfrom
fix/i78-internal-to-external
Open

Fix(#78): replaced internal function reference to external#87
andybeet wants to merge 2 commits into
devfrom
fix/i78-internal-to-external

Conversation

@andybeet

@andybeet andybeet commented Jul 30, 2026

Copy link
Copy Markdown
Member

Justification

survdat had internal functions that were needed for data analysis outside of the package. These were made external functions in the survdat package. As a consequence all reference to them here needed to change from using ::: to ::. This PR makes these changes

Fixes #78

Types of changes

What types of changes does this pull request introduce? Put an x in the boxes that apply.
This will inform the new release number.

  • Fix (non-breaking change which fixes a bug)
  • Feature (non-breaking change which adds or changes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other change (if none of the other choices apply)

Reviewer instructions

Install survdat v2.0.0.
Running any one of the workflows that use survdat should be suffice, exp_n, shannon_survey, or mass_inshore_survey. For example SOEWorkflows::create_mass_inshore_survey(input_path_mass_survey, input_path_species). You can use the example_test_runs.r script as a template. Please don't commit additional example_test scripts, but keep them locally.

Formatting

This repo contains an air.toml file that automatically formats code to a set of standards.
It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.

@andybeet
andybeet marked this pull request as ready for review August 14, 2026 15:27
@andybeet
andybeet requested review from BBeltz1 and MGrezlik August 14, 2026 15:27
@andybeet

Copy link
Copy Markdown
Member Author

@MGrezlik. Your Rpath scripts that used survdat:::post_strat (three colons), will also need to be changed to use ::, (2 colons)

@MGrezlik

Copy link
Copy Markdown
Collaborator

@andybeet Thanks for the reminder. I'll put an issue in that repo. Once we work through all the clam survey issues in the survdat repo I will want to do a fresh pull for the Rpath models

@BBeltz1 BBeltz1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, local test run worked no issue

@andybeet andybeet linked an issue Aug 17, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Replace ::: with :: for survdat functions

3 participants