fix: recover bulk-merge integrations - #177
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bc6224c1b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Decimal, not float: at very large magnitudes (e.g. many PB) float's | ||
| # binary floating-point representation silently loses precision -- | ||
| # verified directly, an off-by-billions error with no warning. | ||
| count = Decimal(value) |
There was a problem hiding this comment.
Inputs such as NaN now raise decimal.InvalidOperation at the subsequent comparison, while a short value such as 1e999999999 reaches fixed-point formatting and attempts to materialize an enormous string, potentially exhausting the public Streamlit worker. human_to_bytes has the same issue before integer conversion. Validate is_finite() and cap the exponent/magnitude before performing either conversion.
Useful? React with 👍 / 👎.
| key = loader.construct_object(key_node, deep=deep) | ||
| if key in mapping: |
There was a problem hiding this comment.
When YAML contains a complex mapping key such as ? [a, b]\n: value, construct_object produces an unhashable list and if key in mapping raises TypeError, which is not caught by the surrounding except yaml.YAMLError; the converter page therefore crashes instead of returning an invalid-YAML result. The identical copied loader in utils/yaml_formatter.py has the same failure, so centralize the constructor and raise ConstructorError for unsupported keys in both callers.
AGENTS.md reference: AGENTS.md:L21-L21
Useful? React with 👍 / 👎.
| ) | ||
| render_section_heading("Optional triage", eyebrow="Step 3a", heading_level="h3") | ||
| render_control_heading("Triage action") | ||
| st.caption("Use this after filtering so the summary reflects the items you are actively reviewing.") |
There was a problem hiding this comment.
After a user applies a query or category filter, this caption promises that triage reflects the items currently under review, but open_items is still derived from board.items and the cached call receives that unfiltered list. Consequently, nonmatching roadmap items are sent to Azure and included in the summary; derive the open-item list from filtered_items or remove the filtering claim.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
.venv/bin/python -m pytest -q— passed.venv/bin/python -m ruff check .— passed.venv/bin/python -m compileall -q app.py pages utils— passed.venv/bin/python -m pip check— passedgit diff --check— passedorigin/main.This PR is intentionally against
mainfrom the isolated repair branch; it does not modifymaindirectly.