Use model-declared ION variable names#4
Open
cjc0013 wants to merge 2 commits into
Open
Conversation
theblackapple5150
requested changes
May 15, 2026
Contributor
theblackapple5150
left a comment
There was a problem hiding this comment.
Thanks for this — this is the right direction and fixes an issue I wanted to address.
I’m going to request a couple small cleanup changes before merging:
- Add the missing comma in the payload dict
- Remove the duplicate meta.json loading block
- Remove the duplicate “Saved as” print
- Adjust output validation so it accepts either the model-defined output variable or data_out as a fallback, instead of requiring both
Once that’s cleaned up, I’m good with merging this.
Author
|
Thanks, fixed those cleanup items in the latest commit. What changed:
Verified locally with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
model.json.data_in/data_outas fallbacks for older models that omit variable metadata.Test plan:
python -m py_compile tools\run.pygit diff --checkCloses #1