Closed
Hard-code dtype_numpy for CMS Pilatus detectors#35
dtype_numpy for CMS Pilatus detectors#35Conversation
Copilot
AI
changed the title
[WIP] Port hard-code of numpy_dtype for Pilatus detectors
Hard-code Jun 4, 2026
dtype_numpy for CMS Pilatus detectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the Pilatus metadata workaround from the OPLS profile into
cms-profile-collection. The change ensures CMS Pilatus detectors always report the expected NumPy dtype in their Bluesky data keys.What changed
CMSPilatusDetectorbase class instartup/20-area-detectors.py.make_data_key()to forcedtype_numpyto"<i4"for Pilatus detector documents.Where it applies
PilatusV33Pilatus800V33Pilatus2MV33PilatusV33_h5Pilatus800V33_h5Why this shape