Add missing <cstdint> to cuvslam2.h - #75
Open
wolfv wants to merge 1 commit into
Open
Conversation
cuvslam2.h uses uint8_t, int32_t and friends (50 occurrences) but includes
only <array>, <functional>, <memory>, <optional>, <string>, <string_view>,
<unordered_map> and <vector>. The fixed-width integer types arrive only
transitively, which GCC 13 happens to do and GCC 15 does not.
Compiling against the header with GCC 15 fails:
cuvslam2.h:162:14: error: use of enum 'Model' without previous declaration
cuvslam2.h:162:22: error: 'uint8_t' was not declared in this scope
cuvslam2.h:162:30: error: default member initializer for unnamed bit-field
cuvslam2.h:169:3: error: 'Model' does not name a type
cuvslam2.h:231:14: error: use of enum 'Encoding' without previous declaration
The sibling cuvslam.h already includes <cstdint>, so this looks like an
oversight when the v2 header was introduced rather than a deliberate choice.
Found while building isaac_ros_visual_slam from source against a GCC 15
toolchain, where it is the only thing preventing the package from compiling.
Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuvslam2.h uses uint8_t, int32_t and friends (50 occurrences) but includes only , , , , , <string_view>, <unordered_map> and . The fixed-width integer types arrive only transitively, which GCC 13 happens to do and GCC 15 does not.
Compiling against the header with GCC 15 fails:
The sibling cuvslam.h already includes , so this looks like an oversight when the v2 header was introduced rather than a deliberate choice.
Found while building isaac_ros_visual_slam from source against a GCC 15 toolchain, where it is the only thing preventing the package from compiling.