sjayaram/k8s excalibur - #5254
Draft
sjayaram-nv wants to merge 10 commits into
Draft
Conversation
sjayaram-nv
requested review from
a team,
erhoo82 and
malay-nagda
as code owners
August 3, 2026 05:34
sjayaram-nv
marked this pull request as draft
August 3, 2026 06:16
malay-nagda
previously approved these changes
Aug 3, 2026
malay-nagda
added
the
needs-review
sudostock
reviewed
Aug 4, 2026
sudostock
reviewed
Aug 4, 2026
Comment on lines
+51
to
+55
| try: | ||
| from nemo_run.core.execution.xcalibur import XCaliburExecutor as _XCaliburExecutor | ||
| except ImportError: | ||
| _XCaliburExecutor = None # type: ignore[assignment,misc] | ||
|
|
Contributor
There was a problem hiding this comment.
This block appears to be unused.
sudostock
reviewed
Aug 4, 2026
sudostock
reviewed
Aug 4, 2026
Comment on lines
+614
to
+615
| # XCalibur uses run_script.py directly; all other executors use bootstrap.py. | ||
| script_name = "run_script.py" if xcalibur_namespace else ENTRYPOINT_BOOTSTRAP |
Contributor
There was a problem hiding this comment.
Why this change? The other executors go through this ENTRYPOINT mechanism. I think doing so skips any recipe level env changes would mean jobs run on xcal and other executors are not apples to apples
Author
There was a problem hiding this comment.
bootstrap.py is a new entrypoint; currently, the container image (nvcr.io/nvidia/nemo:26.04.01) has an older Megatron-Bridge baked into /opt/Megatron-Bridge - it only has run_script.py. This is a temp workaround; will test with nemo container v 26.06 to see if bootstrap.py is available.
sudostock
reviewed
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains changes for adding the XCalibur executor backend to enable llm benchmarking runs in K8s.