-
Notifications
You must be signed in to change notification settings - Fork 458
feat (recipe): add Nemotron 3 Ultra MXFP8 GB200 pretraining perf-recipe #5287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2d66113
feat(perf): add ultra pretrain configurations for Nemotron 3 on GB200
ghadiaravi13 6dff3d4
Merge branch 'main' of https://github.com/NVIDIA-NeMo/Megatron-Bridge…
ghadiaravi13 580d640
refactor(perf): remove unused ultra pretrain config and update relate…
ghadiaravi13 f526067
Merge branch 'main' of https://github.com/NVIDIA-NeMo/Megatron-Bridge…
ghadiaravi13 ab1ae70
test(recipe): allow local constants in environment checks
malay-nagda 38cfd0d
Merge branch 'main' into main-nt3-ultra-mxfp8-gb200
ghadiaravi13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GB200 recipe drives HSDP via
_apply_nemotron_3_ultra_fsdp_hsdp, whose docstring still says "for Nemotron 3 Ultra on GB300", and which computesnum_distributed_optimizer_instancesfrom_GB300_NVLINK_DOMAIN_GPUS = 64(documented as GB300 "16 nodes x 4 GPUs"). For this 256-GPU GB200 recipe that yields256 // 64 = 4optimizer instances. Since this recipe advertisesNVLINK_DOMAIN_SIZE=72while sharding on a 64-GPU domain, please confirm the 64-GPU sharding domain is the intended HSDP grouping for GB200 (it does line up withEP64/NUM_OF_HYBRID_EP_RANKS_PER_NVLINK_DOMAIN=64). If so, consider renaming/generalizing the GB300-specific helper name and constant, or at least updating the docstring so the GB200 reuse isn't surprising.