perf: Reduce MXFP8 refit weight-transfer overheads - #3294
Conversation
|
Isolated-branch reproduction (follow-up promised in the PR body). Setup: Qwen3-30B-A3B GRPO (OpenMathInstruct-2), 2 nodes x 8 B200,
The saving is confined to the refit phase, exactly as claimed; all compute phases and reward are untouched. |
|
/ok to test 740c825 |
|
/ok to test 3f60f5d |
|
Isolated reproduction at 235B scale (follow-up to the 30B numbers above). Setup: Qwen3-235B-A22B GRPO, 8 nodes x 8 B200 (64 GPUs),
The refit-transfer saving grows with model size (30B: 9.7 -> 3.0 s; 235B: 21.8 -> 7.4 s), because larger weights spend proportionally more of the refit in transport - exactly the phase this PR targets. Batched-shuffle bit-exact verify passed on first refit. |
|
/ok to test 04af034 |
|
/ok to test e06f7a8 |
|
/ok to test 3ebdf9d |
Reduce MXFP8 and ModelOpt refit overhead while preserving transport and checkpoint-engine lifecycle correctness. Signed-off-by: sna <sna@nvidia.com>
3ebdf9d to
b88aa2c
Compare
|
/ok to test b88aa2c |
|
/ok to test 438e20d |
Signed-off-by: sna <sna@nvidia.com>
|
/ok to test 96ba299 |
|
/ok to test 96ba299 |
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
…optimization-squashed Signed-off-by: seonjinn <sna@nvidia.com>
Signed-off-by: seonjinn <sna@nvidia.com>
|
/ok to test 2b80a85 |
Signed-off-by: seonjinn <sna@nvidia.com>
|
/ok to test 0b6b5cc |
Signed-off-by: seonjinn <sna@nvidia.com>
|
/ok to test cd7732c |
cd7732c to
5ee7704
Compare
|
/ok to test 5ee7704 |
5ee7704 to
cd7732c
Compare
|
PR decomposition update: I restored the original integrated #3294 branch. The batched MXFP8 MoE shuffle has been extracted unchanged into #3478 for independent review. BF16 trainer storage to MXFP8 vLLM NCCL-Reshard support is tracked separately in #3477. Before merging #3294, I will drop or rebase the extracted shuffle portion onto #3478 so duplicate code does not land. |
|
/ok to test cd7732c |
|
@youngeunkwon0405 could you help review first, i'll review afterwards |
Looks like you have the PR decomposition plan. Then, this PR will be just for a reference? And the decomposed PR will be the actual target for merge? |
PR decomposition
This PR retains the original integrated MXFP8 refit optimization branch and its review history.
What does this PR do?
This PR removes repeated transfer and receiver-side work from the MXFP8 rollout refit path.
Performance
Matched 20-step B200 runs, arithmetic mean over steady-state steps:
On Qwen3-235B-A22B, E2E step time decreased from 314.3 s to 305.0 s and throughput increased from 148.4 to 153.1 tokens/s/GPU, with identical mean rollout reward of 0.57.
Correctness