Restart triage from interrupted run#2113
Open
Steboss wants to merge 4 commits into
Open
Conversation
olupton
reviewed
May 28, 2026
| skip_precondition_checks: bool, | ||
| check_success_before_failure: bool = True, | ||
| confirmation_iterations: int = 1, | ||
| result_cache: typing.Optional[typing.Dict[FlatVersionDict, TestResult]] = None, |
Collaborator
There was a problem hiding this comment.
Suggested change
| result_cache: typing.Optional[typing.Dict[FlatVersionDict, TestResult]] = None, | |
| result_cache: typing.Dict[FlatVersionDict, TestResult] = {}, |
Collaborator
There was a problem hiding this comment.
As well as this, we might not even need _version_search anymore? I think it only existed because of result_cache not being in the top-level API.
Co-authored-by: Olli Lupton <olupton@nvidia.com>
olupton
reviewed
May 29, 2026
| and args.output_prefix.resolve() != args.restart_folder | ||
| ): | ||
| raise Exception( | ||
| "--output-prefix must match --restart-folder when restarting" |
Collaborator
There was a problem hiding this comment.
With these semantics, isn't a boolean --restart sufficient?
| skip_precondition_checks: bool, | ||
| check_success_before_failure: bool = True, | ||
| confirmation_iterations: int = 1, | ||
| result_cache: typing.Optional[typing.Dict[FlatVersionDict, TestResult]] = None, |
Collaborator
There was a problem hiding this comment.
As well as this, we might not even need _version_search anymore? I think it only existed because of result_cache not being in the top-level API.
| result_cache = {} | ||
| if self.args.restart_folder is not None: | ||
| self.restart_cache.update( | ||
| result_cache_from_summary( |
Collaborator
There was a problem hiding this comment.
Why do we have to do this? Why isn't it enough to just populate the in-memory cache from JSON at startup and pass that into the two searches?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.