Fix GTP prefetch parameter readiness - #6232
Open
JF-D wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jiangfei Duan <jiangfeid@nvidia.com>
Contributor
Author
|
@claude strict-review |
Contributor
Author
|
/ok to test 0f18dfe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gtp_cuda_graphs.pyand finish them before replaying each local forward CUDA graphRoot cause
GTP can prefetch the next module's local weight shard before that module executes. With overlapped DDP parameter gathering, the ordinary module pre-forward hook therefore runs too late: GTP may read the distributed-optimizer parameter buffer while its bucket all-gather is still in flight. CUDA graph capture also suppresses the DDP hook, so the dependency must be retained and replayed explicitly.
Each forward graph capture now creates its own
GTPCaptureCommState. The transient active state is used only while capturing; the yielded state is stored on that graph's_CudaGraphRunner, preventing handle sets from aliasing across graph instances.