fix(cli): label the global status inference row as configured - #10471
Conversation
Bare `nemoclaw status` printed each sandbox's registry route under a bare `Inference:` label, the same field name `nemoclaw <name> status` uses for its live route probe (`Inference: healthy (<endpoint>)`). One field name carrying two different meanings reads as a broken rendering, which is how it was reported: the global view looked like it had dropped the health word and the endpoint. Qualify the global row as `Inference (configured):`, following the per-sandbox `Inference (<probe>):` convention, and append the upstream endpoint the registry already records so the row says which upstream it is routed at. The endpoint is redacted, is omitted when the registry has none, and is suppressed for the default sandbox when the live gateway route has drifted off the stored provider, since the stored endpoint no longer describes the route in use. `status --json` reports the same value as `endpointUrl` per sandbox row. This view still runs no inference probe; reachability remains the job of `nemoclaw <name> status`. Fixes #10221 Signed-off-by: Yanyun Liao <yanyunl@nvidia.com>
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit ca96757 in the TypeScript / code-coverage/cliThe overall line coverage in commit ca96757 in the Show a line coverage summary of the most impacted files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-10471.docs.buildwithfern.com/nemoclaw |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughGlobal status now reports configured inference routes with redacted endpoints when applicable. It omits endpoints for missing or provider-drifted routes. Tests and documentation cover text and JSON output. ChangesConfigured inference status
Priority: ➖ Normal — Impact reflects medium issue severity. Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Global status now distinguishes configured inference information from live health results and can display redacted configured endpoints. No concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
…-inference-label-10221
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
PR Review Advisor finished for commit |
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Summary
Bare
nemoclaw statusreported each sandbox route underInference:, the same label that sandbox-scoped status uses for live inference health. This PR changes only the global text label toInference (configured):so the output identifies the route information without changing probes, JSON, lifecycle behavior, or stored state.Closes #10221.
Changes
Inference (configured):.The default sandbox retains its existing live provider and model preference. This PR does not add endpoint rendering or a JSON field.
Type of Change
Quality Gates
Verification
npx vitest run --project cli src/lib/inventory/index.test.ts— 55 tests passed.npm run docs— completed with 0 errors and 5 existing warnings.npm run validate:pr— passed.AI Disclosure
Signed-off-by: Yanyun Liao yanyunl@nvidia.com
Signed-off-by: Apurv Kumaria akumaria@nvidia.com
Signed-off-by: Julie Yaunches jyaunches@nvidia.com