Skip to content

fix(cli): label the global status inference row as configured - #10471

Merged
jyaunches merged 12 commits into
mainfrom
fix/status-configured-inference-label-10221
Sep 8, 2026
Merged

fix(cli): label the global status inference row as configured#10471
jyaunches merged 12 commits into
mainfrom
fix/status-configured-inference-label-10221

Conversation

@yanyunl1991

@yanyunl1991 yanyunl1991 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Bare nemoclaw status reported each sandbox route under Inference:, the same label that sandbox-scoped status uses for live inference health. This PR changes only the global text label to Inference (configured): so the output identifies the route information without changing probes, JSON, lifecycle behavior, or stored state.

Closes #10221.

Changes

  • Change the global status route label to Inference (configured):.
  • Update existing inventory assertions for the qualified label.
  • Document the distinction between global configured-route output and sandbox-scoped live inference status.

The default sandbox retains its existing live provider and model preference. This PR does not add endpoint rendering or a JSON field.

Type of Change

  • Code change with doc updates
  • Code change (feature, bug fix, or refactor)
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Existing tests cover the changed global status rendering.
  • Documentation describes the changed label.
  • No credentials, network access, state mutation, or security boundary changes.

Verification

  • npx vitest run --project cli src/lib/inventory/index.test.ts — 55 tests passed.
  • npm run docs — completed with 0 errors and 5 existing warnings.
  • npm run validate:pr — passed.
  • GitHub CI passed after the label-only scope update except for the PR Review Advisor service returning HTTP 429.
  • DCO declarations are present and every commit is GitHub Verified.

AI Disclosure

  • AI-assisted — DeepSeek Harness

Signed-off-by: Yanyun Liao yanyunl@nvidia.com
Signed-off-by: Apurv Kumaria akumaria@nvidia.com
Signed-off-by: Julie Yaunches jyaunches@nvidia.com

Bare `nemoclaw status` printed each sandbox's registry route under a bare
`Inference:` label, the same field name `nemoclaw <name> status` uses for
its live route probe (`Inference: healthy (<endpoint>)`). One field name
carrying two different meanings reads as a broken rendering, which is how
it was reported: the global view looked like it had dropped the health
word and the endpoint.

Qualify the global row as `Inference (configured):`, following the
per-sandbox `Inference (<probe>):` convention, and append the upstream
endpoint the registry already records so the row says which upstream it
is routed at. The endpoint is redacted, is omitted when the registry has
none, and is suppressed for the default sandbox when the live gateway
route has drifted off the stored provider, since the stored endpoint no
longer describes the route in use. `status --json` reports the same value
as `endpointUrl` per sandbox row.

This view still runs no inference probe; reachability remains the job of
`nemoclaw <name> status`.

Fixes #10221

Signed-off-by: Yanyun Liao <yanyunl@nvidia.com>
@github-code-quality

github-code-quality Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit ca96757 in the fix/status-configure... branch remains at 96%, unchanged from commit 53b7ef1 in the main branch.

TypeScript / code-coverage/cli

The overall line coverage in commit ca96757 in the fix/status-configure... branch remains at 83%, unchanged from commit 9b7d779 in the main branch.

Show a line coverage summary of the most impacted files.
File main 9b7d779 fix/status-configure... ca96757 +/-
src/lib/onboard...on-bootstrap.ts 86% 85% -1%
src/lib/onboard...uild-context.ts 75% 75% 0%
src/lib/sandbox...rce-identity.ts 82% 82% 0%

Updated September 08, 2026 15:58 UTC

@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ae948803-672c-4d32-b6ae-5009e43ec7c8

📥 Commits

Reviewing files that changed from the base of the PR and between 133a188 and 9dbc070.

📒 Files selected for processing (4)
  • docs/reference/commands.mdx
  • src/lib/inventory/index.test.ts
  • src/lib/inventory/index.ts
  • src/lib/inventory/status-configured-inference.test.ts
🚧 Files skipped from review as they are similar to previous changes (4)
  • src/lib/inventory/index.test.ts
  • docs/reference/commands.mdx
  • src/lib/inventory/status-configured-inference.test.ts
  • src/lib/inventory/index.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

Global status now reports configured inference routes with redacted endpoints when applicable. It omits endpoints for missing or provider-drifted routes. Tests and documentation cover text and JSON output.

Changes

Configured inference status

Layer / File(s) Summary
Provider-aware endpoint resolution
src/lib/inventory/index.ts
Status rows now include configured endpoints. URL credentials and unsafe control characters are sanitized. Endpoints are omitted when providers differ or no provider owner exists.
Configured status rendering and validation
src/lib/inventory/index.ts, src/lib/inventory/status-configured-inference.test.ts, src/lib/inventory/index.test.ts, docs/reference/commands.mdx
Global status uses Inference (configured):. Tests and documentation cover endpoint display, omission, redaction, provider drift, JSON output, and the absence of health claims.

Priority: ➖ Normal — Impact reflects medium issue severity.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 9dbc0

Global status now distinguishes configured inference information from live health results and can display redacted configured endpoints. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes satisfy issue [#10221] by distinguishing configured inference data from live health results, displaying the recorded endpoint when valid, and preserving live probing for sandbox-specific s…
Out of Scope Changes check ✅ Passed The code, tests, and documentation changes directly support the linked issue and stated objectives. No unrelated changes are evident.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: labeling the global status inference row as configured. It is concise and related to the pull request objectives.
Full details: Docstring Coverage

Explanation

Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/status-configured-inference-label-10221

Comment @coderabbitai help to get the list of available commands.

@yanyunl1991 yanyunl1991 added area: cli Command line interface, flags, terminal UX, or output bug-fix PR fixes a bug or regression v0.0.115 labels Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@apurvvkumaria apurvvkumaria self-assigned this Aug 30, 2026
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@github-actions github-actions Bot added v0.0.119 v0.0.121 Release target and removed v0.0.118 labels Sep 1, 2026
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@jyaunches jyaunches assigned jyaunches and unassigned apurvvkumaria Sep 8, 2026
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit 7a38a03. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@jyaunches
jyaunches merged commit d35b4df into main Sep 8, 2026
100 of 130 checks passed
@jyaunches
jyaunches deleted the fix/status-configured-inference-label-10221 branch September 8, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: cli Command line interface, flags, terminal UX, or output bug-fix PR fixes a bug or regression v0.0.121 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bare nemoclaw status shows provider/model instead of the documented healthy(endpoint) Inference format

4 participants