Skip to content

test(e2e): wait for drained Hermes cron schedule #8405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjagwani wants to merge 4 commits into from
Closed

test(e2e): wait for drained Hermes cron schedule #8405

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
283fde9
test(e2e): wait for drained Hermes cron schedule
cjagwani Aug 5, 2026
08575c0
test(e2e): tolerate Hermes restart transition
cjagwani Aug 5, 2026
a72351a
merge(main): refresh PR #8405
cjagwani Aug 5, 2026
da173d3
merge: resolve conflicts with main
github-actions[bot] Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions test/e2e/support/rebuild-hermes-cron-restore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@

import { describe, expect, it } from "vitest";
import {
hermesCronJobIsDue,

Check failure on line 6 in test/e2e/support/rebuild-hermes-cron-restore.test.ts

View workflow job for this annotation

GitHub Actions / build-typecheck 

Module '"../live/rebuild-hermes-cron-restore.ts"' has no exported member 'hermesCronJobIsDue'.
hermesCronJobRuntimeState,
parseHermesCronBeginReceipt,
parseHermesGatewayEvidence,
} from "../live/rebuild-hermes-cron-restore.ts";

describe("Hermes rebuild cron restore evidence", () => {
Expand Down Expand Up @@ -69,4 +71,35 @@
start_time: 47767,
});
});

it("distinguishes naturally due cron work from future work", () => {
const job = {
last_run_at: null,
last_status: null,
next_run_at: "2026-08-06T19:41:01.000Z",
repeat: { completed: 0, times: null },
state: "scheduled",
};

expect(hermesCronJobIsDue(job, "cron job fixture", Date.parse("2026-08-06T19:41:00Z"))).toBe(

Check failure on line 84 in test/e2e/support/rebuild-hermes-cron-restore.test.ts

View workflow job for this annotation

GitHub Actions / cli-test-shards (2)

[e2e-support] test/e2e/support/rebuild-hermes-cron-restore.test.ts > Hermes rebuild cron restore evidence > distinguishes naturally due cron work from future work 

TypeError: hermesCronJobIsDue is not a function
 ❯ test/e2e/support/rebuild-hermes-cron-restore.test.ts:84:12
false,
);
expect(hermesCronJobIsDue(job, "cron job fixture", Date.parse("2026-08-06T19:41:01Z"))).toBe(
true,
);
});

it("accepts a transient missing gateway process while restart polling continues", () => {
expect(
parseHermesGatewayEvidence(
'{"active_agents":0,"gateway_state":"draining","pid":263,"running_pid":null,"start_time":38291}',
),
).toEqual({
active_agents: 0,
gateway_state: "draining",
pid: 263,
running_pid: null,
start_time: 38291,
});
});
});
Loading