fix(hermes): repair legacy dashboard startup - #8550
Conversation
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughWalkthroughHermes dashboard argument construction now includes ChangesHermes dashboard execution
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
Maintainer security review for candidate
No manual E2E workflow was dispatched. |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 931fc55 in the TypeScript / code-coverage/cliThe overall coverage in commit 931fc55 in the Show a code coverage summary of the most impacted files.
Updated |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/hermes-start.test.ts`:
- Around line 851-854: Update the test case “keeps the managed dashboard
isolated and its in-browser Hermes TUI opt-in” to also assert that
defaultArgs.stdout.split("\n") contains “--isolated”, while preserving the
existing status and --tui omission assertions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: cc4f368c-ef6e-4335-8cfd-e6ef8ffdde3d
📒 Files selected for processing (2)
agents/hermes/start.shtest/hermes-start.test.ts
| it("keeps the managed dashboard isolated and its in-browser Hermes TUI opt-in", () => { | ||
| const defaultArgs = runHermesDashboardArgs(); | ||
| expect(defaultArgs.status).toBe(0); | ||
| expect(defaultArgs.stdout.split("\n")).not.toContain("--tui"); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Assert --isolated for the default dashboard path.
Lines 852-854 only verify that default arguments omit --tui. A regression that removes --isolated from the default path would still pass. Add an assertion that defaultArgs.stdout.split("\n") contains --isolated.
Proposed test assertion
const defaultArgs = runHermesDashboardArgs();
expect(defaultArgs.status).toBe(0);
+ expect(defaultArgs.stdout.split("\n")).toContain("--isolated");
expect(defaultArgs.stdout.split("\n")).not.toContain("--tui");📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| it("keeps the managed dashboard isolated and its in-browser Hermes TUI opt-in", () => { | |
| const defaultArgs = runHermesDashboardArgs(); | |
| expect(defaultArgs.status).toBe(0); | |
| expect(defaultArgs.stdout.split("\n")).not.toContain("--tui"); | |
| it("keeps the managed dashboard isolated and its in-browser Hermes TUI opt-in", () => { | |
| const defaultArgs = runHermesDashboardArgs(); | |
| expect(defaultArgs.status).toBe(0); | |
| expect(defaultArgs.stdout.split("\n")).toContain("--isolated"); | |
| expect(defaultArgs.stdout.split("\n")).not.toContain("--tui"); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/hermes-start.test.ts` around lines 851 - 854, Update the test case
“keeps the managed dashboard isolated and its in-browser Hermes TUI opt-in” to
also assert that defaultArgs.stdout.split("\n") contains “--isolated”, while
preserving the existing status and --tui omission assertions.
Source: Path instructions
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
2 terminology differences from the second opinionAdvisory only. These are normalized differences from the primary terminology receipt.
2 additional E2E selections from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 1 semantic terminology decisionTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: 1 warning · 0 suggestionsWarningsWarnings do not block.
|
3 participants
Summary
--isolatedflag.profiles/dashboard-homeas a request to re-exec into its unified machine-level Dashboard.Affected main evidence
sandbox-images-and-e2e / test-hermes-sandbox-image(92846562212)c31724f4e66e4d9abd0baab2ff68181830a4750ahermes root-entrypoint smoke preserves runtime layout and legacy state migration127.0.0.1:19119; the container exits 1.Root cause
Hermes v2026.7.20 infers a named profile from a
HERMES_HOMEpath underprofiles/<name>. Without--isolated,hermes dashboardroutes that launch to its unified machine-level Dashboard and leaves NemoClaw's prepared profile boundary. The legacy-state variant populates that profile before launch, exposing the route and causing the Dashboard owner to exit before the internal port binds.Ownership search
19119, orstart_socat_forwarderpath.agents/hermes/start.shortest/e2e/live/hermes-root-entrypoint-smoke.test.ts.Validation
npx vitest run --project integration test/hermes-start.test.ts test/hermes-dashboard-credential-launch.test.ts test/hermes-dashboard-profile-migration-security.test.ts(47 passed)npm run build:clinpm run validate:prtest/seed-hermes-dashboard-config.test.tsreproduce unchanged onmain; they are outside this patch and this root cause.Security review
--isolatedkeeps the Dashboard in the sandbox-owned profile that NemoClaw already prepares and permission-separates.Signed-off-by: Prekshi Vyas prekshiv@nvidia.com
Summary by CodeRabbit
Bug Fixes
Tests