fix: Guard FP4 data type before TensorRT 10.8 - #145
Open
suharvest wants to merge 1 commit into
Open
Conversation
Signed-off-by: suharvest <suharvest@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Guards the two remaining
nvinfer1::DataType::kFP4references inFusedNvfp4GemmAllReducePlugin::supportsFormatCombination()so the source canbe compiled with TensorRT releases before 10.8, where that enum value does not
exist.
For TensorRT 10.8 and newer, the original FP4/INT8/FP8 acceptance expression is
unchanged. For older TensorRT releases, the existing INT8 and FP8 alternatives
remain available without referencing
kFP4.Scope
Validation
10.7, 10.8, and 11.0 version macros.
DataType::kFP4references.git diff --checkpasses.The machine used for this focused validation does not have a Jetson
TensorRT/CUDA toolchain, so a complete JetPack 6.2 plugin build is still
requested from CI or device validation.
Closes #141.