Skip to content

fix: Guard FP4 data type before TensorRT 10.8 - #145

Open
suharvest wants to merge 1 commit into
NVIDIA:mainfrom
suharvest:pr/fix-trt-pre108-fp4-guard
Open

fix: Guard FP4 data type before TensorRT 10.8#145
suharvest wants to merge 1 commit into
NVIDIA:mainfrom
suharvest:pr/fix-trt-pre108-fp4-guard

Conversation

@suharvest

Copy link
Copy Markdown

What does this PR do?

Guards the two remaining nvinfer1::DataType::kFP4 references in
FusedNvfp4GemmAllReducePlugin::supportsFormatCombination() so the source can
be compiled with TensorRT releases before 10.8, where that enum value does not
exist.

For TensorRT 10.8 and newer, the original FP4/INT8/FP8 acceptance expression is
unchanged. For older TensorRT releases, the existing INT8 and FP8 alternatives
remain available without referencing kFP4.

Scope

  • One source file.
  • No plugin ABI, serialization, kernel, or model changes.
  • No behavior change for TensorRT 10.8+.

Validation

  • Focused compile/preprocessor matrix passed for simulated TensorRT 10.3,
    10.7, 10.8, and 11.0 version macros.
  • TensorRT 10.7 preprocessing contains no DataType::kFP4 references.
  • TensorRT 10.8 preprocessing retains both original FP4 checks.
  • An unguarded negative control fails against the pre-10.8 enum as expected.
  • git diff --check passes.

The machine used for this focused validation does not have a Jetson
TensorRT/CUDA toolchain, so a complete JetPack 6.2 plugin build is still
requested from CI or device validation.

Closes #141.

Signed-off-by: suharvest <suharvest@gmail.com>
@suharvest
suharvest requested a review from a team July 25, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Runtime]: FP4 plugin source does not compile with TensorRT versions before 10.8

1 participant