fix(attention): Scope FMHA cubin loading by mask type - #148
Open
suharvest wants to merge 1 commit into
Open
Conversation
Signed-off-by: suharvest <suharvest@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Scopes context-FMHA cubin loading and caching by the requested attention mask
type.
Previously the load cache key contained only data type and SM. Constructing a
list then attempted to load every matching data-type/SM cubin before the mask
type was considered during function lookup. An unrelated custom-mask cubin
could therefore fail with
CUDA_ERROR_INVALID_IMAGEwhile initializing acausal model.
The requested mask type now participates in:
Every caller passes its mask explicitly; the public load function has no
default mask argument. A real custom-mask request still loads the custom-mask
cubin and propagates load failures—there is no fallback to a different mask.
Scope
Validation
filtering, cache lookup, availability, and dispatch.
git diff --checkand merge-tree validation pass.The validation machine has no CUDA/TensorRT toolchain, so native compilation,
the non-custom-mask positive engine case, and a real invalid custom-mask cubin
negative test are still requested from CI/device testing.
Closes #143.