bugprone-exception-escape

[Jacobfaib]

Description

closes

Checklist

• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

libcudacxx/include/cuda/__driver/driver_api.h (1)

295-300: ⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

important: these newly noexcept *NoThrow wrappers still perform function-local static driver-symbol resolution through _CCCLRT_GET_DRIVER_FUNCTION(...), which can throw from __get_driver_entry_point(...). In a noexcept function this turns lookup failures into std::terminate instead of returning cudaError_t. Please make the lookup path non-throwing for *NoThrow wrappers (e.g., no-throw resolver + error-code fallback) and keep throwing lookup only in throwing wrappers.

Also applies to: 433-439, 455-460, 487-492, 509-516, 555-565, 607-625, 637-645, 664-669, 745-750, 768-773, 785-790, 800-805, 881-886, 898-925, 929-953, 998-1005, 1020-1025

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6586f809-9764-48dc-96ae-4da77454e380

📥 Commits

Reviewing files that changed from the base of the PR and between a4ffbcf and e86b5ab.

📒 Files selected for processing (57)

• .clang-tidy
• cub/examples/device/example_device_radix_sort_custom.cu
• cub/examples/device/example_device_topk_keys.cu
• cub/examples/device/example_device_topk_pairs.cu
• cub/test/test_device_batch_copy.cu
• cub/test/test_namespace_wrapped.cu
• cudax/examples/vector.cuh
• libcudacxx/include/cuda/__driver/driver_api.h
• libcudacxx/include/cuda/std/__memory/allocator_traits.h
• libcudacxx/include/cuda/std/__optional/optional_ref.h
• thrust/examples/arbitrary_transformation.cu
• thrust/examples/basic_vector.cu
• thrust/examples/bucket_sort2d.cu
• thrust/examples/constant_iterator.cu
• thrust/examples/counting_iterator.cu
• thrust/examples/cuda/custom_temporary_allocation.cu
• thrust/examples/cuda/range_view.cu
• thrust/examples/discrete_voronoi.cu
• thrust/examples/dot_products_with_zip.cu
• thrust/examples/expand.cu
• thrust/examples/fill_copy_sequence.cu
• thrust/examples/histogram.cu
• thrust/examples/include/timer.h
• thrust/examples/lambda.cu
• thrust/examples/lexicographical_sort.cu
• thrust/examples/max_abs_diff.cu
• thrust/examples/minmax.cu
• thrust/examples/mode.cu
• thrust/examples/mr_basic.cu
• thrust/examples/norm.cu
• thrust/examples/permutation_iterator.cu
• thrust/examples/repeated_range.cu
• thrust/examples/run_length_encoding.cu
• thrust/examples/saxpy.cu
• thrust/examples/scan_by_key.cu
• thrust/examples/set_operations.cu
• thrust/examples/simple_moving_average.cu
• thrust/examples/sort.cu
• thrust/examples/sorting_aos_vs_soa.cu
• thrust/examples/sum.cu
• thrust/examples/summary_statistics.cu
• thrust/examples/summed_area_table.cu
• thrust/examples/tiled_range.cu
• thrust/examples/transform_input_output_iterator.cu
• thrust/examples/transform_output_iterator.cu
• thrust/examples/weld_vertices.cu
• thrust/examples/word_count.cu
• thrust/testing/mr_disjoint_pool.cu
• thrust/testing/mr_pool.cu
• thrust/thrust/detail/allocator/temporary_allocator.h
• thrust/thrust/detail/contiguous_storage.h
• thrust/thrust/detail/vector_base.h
• thrust/thrust/device_vector.h
• thrust/thrust/host_vector.h
• thrust/thrust/mr/allocator.h
• thrust/thrust/mr/disjoint_pool.h
• thrust/thrust/mr/pool.h

💤 Files with no reviewable changes (1)

• .clang-tidy

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 838e2027-35d7-4853-91fd-a79b201f91a1

📥 Commits

Reviewing files that changed from the base of the PR and between 6a37eb9 and 8bfa00f.

📒 Files selected for processing (60)

• .clang-tidy
• ci/matrix.yaml
• cub/examples/device/example_device_radix_sort_custom.cu
• cub/examples/device/example_device_topk_keys.cu
• cub/examples/device/example_device_topk_pairs.cu
• cub/test/test_device_batch_copy.cu
• cub/test/test_namespace_wrapped.cu
• cudax/examples/vector.cuh
• libcudacxx/include/cuda/__driver/driver_api.h
• libcudacxx/include/cuda/std/__memory/allocator_traits.h
• libcudacxx/include/cuda/std/__optional/optional_ref.h
• libcudacxx/test/libcudacxx/std/utilities/optional/optional.object/optional.object.observe/value.pass.cpp
• libcudacxx/test/libcudacxx/std/utilities/optional/optional.object/optional.object.observe/value_const_rvalue.pass.cpp
• thrust/examples/arbitrary_transformation.cu
• thrust/examples/basic_vector.cu
• thrust/examples/bucket_sort2d.cu
• thrust/examples/constant_iterator.cu
• thrust/examples/counting_iterator.cu
• thrust/examples/cuda/custom_temporary_allocation.cu
• thrust/examples/cuda/range_view.cu
• thrust/examples/discrete_voronoi.cu
• thrust/examples/dot_products_with_zip.cu
• thrust/examples/expand.cu
• thrust/examples/fill_copy_sequence.cu
• thrust/examples/histogram.cu
• thrust/examples/include/timer.h
• thrust/examples/lambda.cu
• thrust/examples/lexicographical_sort.cu
• thrust/examples/max_abs_diff.cu
• thrust/examples/minmax.cu
• thrust/examples/mode.cu
• thrust/examples/mr_basic.cu
• thrust/examples/norm.cu
• thrust/examples/permutation_iterator.cu
• thrust/examples/repeated_range.cu
• thrust/examples/run_length_encoding.cu
• thrust/examples/saxpy.cu
• thrust/examples/scan_by_key.cu
• thrust/examples/set_operations.cu
• thrust/examples/simple_moving_average.cu
• thrust/examples/sort.cu
• thrust/examples/sorting_aos_vs_soa.cu
• thrust/examples/sum.cu
• thrust/examples/summary_statistics.cu
• thrust/examples/summed_area_table.cu
• thrust/examples/tiled_range.cu
• thrust/examples/transform_input_output_iterator.cu
• thrust/examples/transform_output_iterator.cu
• thrust/examples/weld_vertices.cu
• thrust/examples/word_count.cu
• thrust/testing/mr_disjoint_pool.cu
• thrust/testing/mr_pool.cu
• thrust/thrust/detail/allocator/temporary_allocator.h
• thrust/thrust/detail/contiguous_storage.h
• thrust/thrust/detail/vector_base.h
• thrust/thrust/device_vector.h
• thrust/thrust/host_vector.h
• thrust/thrust/mr/allocator.h
• thrust/thrust/mr/disjoint_pool.h
• thrust/thrust/mr/pool.h

✅ Files skipped from review due to trivial changes (52)

• thrust/thrust/device_vector.h
• thrust/examples/permutation_iterator.cu
• thrust/examples/lambda.cu
• thrust/examples/counting_iterator.cu
• thrust/thrust/mr/disjoint_pool.h
• thrust/examples/tiled_range.cu
• thrust/examples/fill_copy_sequence.cu
• thrust/examples/norm.cu
• thrust/thrust/detail/allocator/temporary_allocator.h
• thrust/examples/transform_input_output_iterator.cu
• thrust/examples/summed_area_table.cu
• cub/test/test_namespace_wrapped.cu
• thrust/examples/scan_by_key.cu
• thrust/examples/saxpy.cu
• thrust/thrust/detail/vector_base.h
• libcudacxx/test/libcudacxx/std/utilities/optional/optional.object/optional.object.observe/value_const_rvalue.pass.cpp
• thrust/examples/expand.cu
• thrust/examples/bucket_sort2d.cu
• thrust/examples/dot_products_with_zip.cu
• thrust/examples/weld_vertices.cu
• cub/examples/device/example_device_topk_pairs.cu
• thrust/examples/cuda/custom_temporary_allocation.cu
• thrust/thrust/mr/pool.h
• thrust/examples/sum.cu
• thrust/thrust/detail/contiguous_storage.h
• thrust/examples/mr_basic.cu
• cub/examples/device/example_device_topk_keys.cu
• thrust/examples/transform_output_iterator.cu
• thrust/examples/sort.cu
• thrust/examples/basic_vector.cu
• thrust/testing/mr_pool.cu
• libcudacxx/test/libcudacxx/std/utilities/optional/optional.object/optional.object.observe/value.pass.cpp
• thrust/thrust/host_vector.h
• libcudacxx/include/cuda/std/__memory/allocator_traits.h
• thrust/examples/histogram.cu
• thrust/examples/max_abs_diff.cu
• thrust/examples/minmax.cu
• thrust/examples/constant_iterator.cu
• cub/test/test_device_batch_copy.cu
• thrust/examples/repeated_range.cu
• thrust/thrust/mr/allocator.h
• thrust/examples/set_operations.cu
• thrust/examples/simple_moving_average.cu
• thrust/testing/mr_disjoint_pool.cu
• thrust/examples/word_count.cu
• thrust/examples/run_length_encoding.cu
• thrust/examples/discrete_voronoi.cu
• thrust/examples/summary_statistics.cu
• thrust/examples/arbitrary_transformation.cu
• thrust/examples/sorting_aos_vs_soa.cu
• thrust/examples/lexicographical_sort.cu
• cub/examples/device/example_device_radix_sort_custom.cu

🚧 Files skipped from review as they are similar to previous changes (7)

• thrust/examples/mode.cu
• thrust/examples/cuda/range_view.cu
• libcudacxx/include/cuda/std/__optional/optional_ref.h
• thrust/examples/include/timer.h
• .clang-tidy
• cudax/examples/vector.cuh
• libcudacxx/include/cuda/__driver/driver_api.h

[Jacobfaib]

Tried to bump the clang-tidy version to clang 22 but due to issues in upstream LLVM, this might not be possible (yet). See rapidsai/devcontainers#725

[davebayer]

Hmm, but clang-tidy is actually right about these. __get_driver_entry_point can throw. However, I don't know what we should do about that

[Jacobfaib]

If __get_driver_entry_point throws then we are basically screwed and will end up aborting 99/100 anyways. We can't construct most of our globals like cuda::devices, most of these nothrow functions are called in destructors or when constructing/handling other exceptions.

[davebayer]

Yeah.. Maybe we should make __get_driver_entry_point `noexcept and exit in case of any problems there

[Jacobfaib]

@pciolkosz wdyt^^?

[github-actions]

😬 CI Workflow Results

🟥 Finished in 23h 47m: Pass: 99%/506 | Total: 7d 14h | Max: 1h 10m | Hits: 99%/653445

See results here.