Cover cuco .hpp headers in cudax header testing#9696
Conversation
.hpp headers in cudax header testing
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe non-STF header test generation in cudaxHeaderTesting.cmake now globs an additional header pattern, ChangesHeader Testing Glob Update
Sequence Diagram(s)Not applicable; this is a build configuration glob pattern change with no observable runtime flow. Estimated code review effort: 1 (trivial) Related issues: None provided. Related PRs: None provided. Suggested labels: cmake, build Suggested reviewers: None provided. suggestion: confirm __cuco headers are self-contained/compilable standalone, since header tests compile each header in isolation. Comment |
| # cuco carries some `.hpp` headers; scope the glob to `__cuco` so we don't pull in the | ||
| # untested `__nccl`/`__multi_gpu` `.h` headers. | ||
| "cuda/experimental/__cuco/*.hpp" |
There was a problem hiding this comment.
If reviewers think it's appropriate, I can also extend the coverage to all cudax .hpp and .h headers.
🥳 CI Workflow Results🟩 Finished in 1h 27m: Pass: 100%/53 | Total: 17h 09m | Max: 1h 08m | Hits: 35%/103721See results here. |
The cudax header test only globs
cuda/experimental/*.cuh, so any.hppheader is silently untested for self-containment. As cuco is migrated into cudax, some of its headers carry the.hppextension, which would slip through. This PR adds acuda/experimental/__cuco/*.hppglob to the non-STF header test, scoped to__cucoso it does not pull in the untested__nccl/__multi_gpu.hheaders.