Skip to content

Cover cuco .hpp headers in cudax header testing#9696

Open
PointKernel wants to merge 3 commits into
NVIDIA:mainfrom
PointKernel:cudax-test-cuco-hpp-headers
Open

Cover cuco .hpp headers in cudax header testing#9696
PointKernel wants to merge 3 commits into
NVIDIA:mainfrom
PointKernel:cudax-test-cuco-hpp-headers

Conversation

@PointKernel

@PointKernel PointKernel commented Jul 2, 2026

Copy link
Copy Markdown
Member

The cudax header test only globs cuda/experimental/*.cuh, so any .hpp header is silently untested for self-containment. As cuco is migrated into cudax, some of its headers carry the .hpp extension, which would slip through. This PR adds a cuda/experimental/__cuco/*.hpp glob to the non-STF header test, scoped to __cuco so it does not pull in the untested __nccl/__multi_gpu .h headers.

@PointKernel PointKernel requested a review from a team as a code owner July 2, 2026 20:04
@PointKernel PointKernel requested a review from griwes July 2, 2026 20:04
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Jul 2, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Jul 2, 2026
@PointKernel PointKernel changed the title Cudax test cuco hpp headers Cover cuco .hpp headers in cudax header testing Jul 2, 2026
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 16e75556-92da-4615-b4ed-143322a99470

📥 Commits

Reviewing files that changed from the base of the PR and between a1fb0b8 and e32a746.

📒 Files selected for processing (1)
  • cudax/cmake/cudaxHeaderTesting.cmake

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Expanded header test coverage to include additional experimental C++ headers, improving validation of public header builds.

Walkthrough

The non-STF header test generation in cudaxHeaderTesting.cmake now globs an additional header pattern, cuda/experimental/__cuco/*.hpp, alongside the existing cuda/experimental/*.cuh pattern.

Changes

Header Testing Glob Update

Layer / File(s) Summary
Expand header glob pattern
cudax/cmake/cudaxHeaderTesting.cmake
Adds cuda/experimental/__cuco/*.hpp glob in addition to existing cuda/experimental/*.cuh for non-STF header test generation.

Sequence Diagram(s)

Not applicable; this is a build configuration glob pattern change with no observable runtime flow.

Estimated code review effort: 1 (trivial)

Related issues: None provided.

Related PRs: None provided.

Suggested labels: cmake, build

Suggested reviewers: None provided.

suggestion: confirm __cuco headers are self-contained/compilable standalone, since header tests compile each header in isolation.


Comment @coderabbitai help to get the list of available commands.

Comment on lines +23 to +25
# cuco carries some `.hpp` headers; scope the glob to `__cuco` so we don't pull in the
# untested `__nccl`/`__multi_gpu` `.h` headers.
"cuda/experimental/__cuco/*.hpp"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If reviewers think it's appropriate, I can also extend the coverage to all cudax .hpp and .h headers.

@PointKernel PointKernel added the cudax Feature intended for the cudax experimental library label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 1h 27m: Pass: 100%/53 | Total: 17h 09m | Max: 1h 08m | Hits: 35%/103721

See results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudax Feature intended for the cudax experimental library

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

1 participant