-
Notifications
You must be signed in to change notification settings - Fork 60
[NIXL] ASIO support #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[NIXL] ASIO support #996
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2249665
nixl asio support
podkidyshev 8e4dfa9
fix asio startup
podkidyshev 7dacb01
code cleanup
podkidyshev 9f3775b
restore backwards compatibility
podkidyshev 2aee117
remove redundant case handling
podkidyshev 1676f2a
rename prop
podkidyshev 9bf13b3
updated nixl configs
podkidyshev 1fe0be1
simplify config
podkidyshev 08fd99c
Merge branch 'main' into ipod/nixl-asio
podkidyshev 9eafbf5
fix copyright headers
podkidyshev 747f726
remove redundant comments
podkidyshev a86b878
Merge branch 'main' into ipod/nixl-asio
rutayan-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "nixl-bench-posix" | ||
| description = "Small NIXLBench POSIX storage smoke test" | ||
| test_template_name = "NIXLBench" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "nvcr.io#nvidia/cuda-dl-base:26.06-cuda13.3-inference-devel-ubuntu24.04" | ||
| path_to_benchmark = "nixlbench" | ||
| etcd_image_url = "sourcemation/etcd:3.6.13" | ||
| etcd_path = "/usr/local/bin/etcd" | ||
| backend = "POSIX" | ||
| filepath = "/data" | ||
| posix_api_type = "AIO" | ||
| op_type = "WRITE" | ||
| total_buffer_size = "64mb" | ||
| start_block_size = 4096 | ||
| max_block_size = 1048576 | ||
| start_batch_size = 1 | ||
| max_batch_size = 1 | ||
| warmup_iter = 5 | ||
| num_iter = 20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "nixl-bench-ucx" | ||
| description = "Small NIXLBench UCX smoke test using host memory" | ||
| test_template_name = "NIXLBench" | ||
|
|
||
| [cmd_args] | ||
| docker_image_url = "nvcr.io#nvidia/cuda-dl-base:26.06-cuda13.3-inference-devel-ubuntu24.04" | ||
| path_to_benchmark = "nixlbench" | ||
| etcd_image_url = "sourcemation/etcd:3.6.13" | ||
| etcd_path = "/usr/local/bin/etcd" | ||
| backend = "UCX" | ||
| initiator_seg_type = "DRAM" | ||
| target_seg_type = "DRAM" | ||
| op_type = "WRITE" | ||
| total_buffer_size = "64mb" | ||
| start_block_size = 4096 | ||
| max_block_size = 1048576 | ||
| start_batch_size = 1 | ||
| max_batch_size = 1 | ||
| warmup_iter = 5 | ||
| num_iter = 20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "nixl-bench-network" | ||
|
|
||
| [[Tests]] | ||
| id = "nixl-bench-network.etcd.1node" | ||
| num_nodes = 1 | ||
| time_limit = "00:05:00" | ||
| test_name = "nixl-bench-ucx" | ||
| description = "NIXLBench ETCD smoke test with two processes on one node" | ||
|
|
||
| [Tests.cmd_args] | ||
| runtime_type = "ETCD" | ||
|
|
||
| [[Tests]] | ||
| id = "nixl-bench-network.etcd.2nodes" | ||
| num_nodes = 2 | ||
| time_limit = "00:05:00" | ||
| test_name = "nixl-bench-ucx" | ||
| description = "NIXLBench ETCD smoke test with one process per node" | ||
|
|
||
| [Tests.cmd_args] | ||
| runtime_type = "ETCD" | ||
|
|
||
| [[Tests]] | ||
| id = "nixl-bench-network.asio.1node" | ||
| num_nodes = 1 | ||
| time_limit = "00:05:00" | ||
| test_name = "nixl-bench-ucx" | ||
| description = "NIXLBench ASIO smoke test with two processes on one node" | ||
|
|
||
| [Tests.cmd_args] | ||
| runtime_type = "ASIO" | ||
|
|
||
| [[Tests]] | ||
| id = "nixl-bench-network.asio.2nodes" | ||
| num_nodes = 2 | ||
| time_limit = "00:05:00" | ||
| test_name = "nixl-bench-ucx" | ||
| description = "NIXLBench ASIO smoke test with one process per node" | ||
|
|
||
| [Tests.cmd_args] | ||
| runtime_type = "ASIO" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "nixl-bench-storage" | ||
|
|
||
| [[Tests]] | ||
| id = "nixl-bench-storage.posix.null-runtime" | ||
| num_nodes = 1 | ||
| time_limit = "00:05:00" | ||
| test_name = "nixl-bench-posix" | ||
| description = "NIXLBench POSIX smoke test without ETCD" | ||
|
|
||
| [Tests.cmd_args] | ||
| etcd_endpoints = "" | ||
|
|
||
| [[Tests]] | ||
| id = "nixl-bench-storage.posix.etcd" | ||
| num_nodes = 1 | ||
| time_limit = "00:05:00" | ||
| test_name = "nixl-bench-posix" | ||
| description = "NIXLBench POSIX smoke test with managed ETCD" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.