pre-commit: update 'cython-lint' to 0.21.1 - #23842
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pre-commit configuration updates the ChangesPre-commit hook maintenance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change updates the pre-commit cython-lint version for Cython 3.3.0+ compatibility without introducing an actionable merge-blocking risk. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
The triage job looked stuck. It was queued for ~5hrs. Tried removing and readding a label. Then just tried restarting it. |
|
Ok looks like updating the branch did the trick |
|
/merge |
Description
Contributes to rapidsai/build-planning#317
cython-lint0.21.1 contains a fix for compatibility with Cython 3.3.0+. This PR hopefully avoids us needing to bumpcython-lintwhen cuDF starts using Cython 3.3.0+.Notes for Reviewers
I left all the other pins in place
My understanding from #23767 was that cuDF intends to have a consistent upper bound on Cython everywhere (conda recipes, wheel dependencies,
pre-commit, etc.).So even though that
<3.3.0a0ceiling is no longer necessary forcython-lintto work as of this PR, I left it alone.Checklist