Skip to content

pre-commit: update 'cython-lint' to 0.21.1 - #23842

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
jameslamb:cython-lint
Aug 26, 2026
Merged

pre-commit: update 'cython-lint' to 0.21.1#23842
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
jameslamb:cython-lint

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Description

Contributes to rapidsai/build-planning#317

cython-lint 0.21.1 contains a fix for compatibility with Cython 3.3.0+. This PR hopefully avoids us needing to bump cython-lint when cuDF starts using Cython 3.3.0+.

Notes for Reviewers

I left all the other pins in place

My understanding from #23767 was that cuDF intends to have a consistent upper bound on Cython everywhere (conda recipes, wheel dependencies, pre-commit, etc.).

So even though that <3.3.0a0 ceiling is no longer necessary for cython-lint to work as of this PR, I left it alone.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb
jameslamb requested a review from a team as a code owner August 26, 2026 15:17
@jameslamb jameslamb added the improvement Improvement / enhancement to an existing function label Aug 26, 2026
@jameslamb jameslamb added the non-breaking Non-breaking change label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 96341d33-7f22-43f5-8335-1ad7c36017ef

📥 Commits

Reviewing files that changed from the base of the PR and between 09dfa18 and 30dc755.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the code quality check tooling to a newer patch version.

Walkthrough

The pre-commit configuration updates the cython-lint hook from revision v0.21.0 to v0.21.1.

Changes

Pre-commit hook maintenance

Layer / File(s) Summary
Update cython-lint revision
.pre-commit-config.yaml
The cython-lint hook now uses revision v0.21.1 instead of v0.21.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 30dc7

This localized change updates the pre-commit cython-lint version for Cython 3.3.0+ compatibility without introducing an actionable merge-blocking risk.

Suggested reviewers: kylefromnvidia, bdice, vyasr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the cython-lint version update, its Cython 3.3.0+ compatibility purpose, and the unchanged version pins. It is directly related to the changeset.
Title check ✅ Passed The title clearly and concisely identifies the pre-commit cython-lint update from the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jakirkham jakirkham added non-breaking Non-breaking change and removed non-breaking Non-breaking change labels Aug 26, 2026
@jakirkham

Copy link
Copy Markdown
Contributor

The triage job looked stuck. It was queued for ~5hrs. Tried removing and readding a label. Then just tried restarting it.

@jakirkham jakirkham removed their assignment Aug 26, 2026
@jakirkham

Copy link
Copy Markdown
Contributor

Ok looks like updating the branch did the trick

@jakirkham

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 42cdab8 into NVIDIA:main Aug 26, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants