Skip to content

wheels: declare 'cuda-pathfinder' dependency for libcudf - #23880

Merged
vyasr merged 1 commit into
NVIDIA:mainfrom
jameslamb:pathfinder-dep
Aug 29, 2026
Merged

wheels: declare 'cuda-pathfinder' dependency for libcudf#23880
vyasr merged 1 commit into
NVIDIA:mainfrom
jameslamb:pathfinder-dep

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Description

Follow-up to #23414

Contributes to rapidsai/build-planning#307

libcudf wheels use cuda-pathfinder:

from cuda.pathfinder import load_nvidia_dynamic_lib
load_nvidia_dynamic_lib("nvJitLink")
load_nvidia_dynamic_lib("nvrtc")

But don't explicitly declare a dependency on it. This fixes that.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb
jameslamb requested a review from a team as a code owner August 28, 2026 20:37
@jameslamb
jameslamb requested a review from msarahan August 28, 2026 20:37
@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 28, 2026
@github-actions github-actions Bot added the Python Affects Python cuDF API. label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 001205c8-ca65-445c-ae7e-6ff66a7d0500

📥 Commits

Reviewing files that changed from the base of the PR and between ea199db and d440da1.

📒 Files selected for processing (2)
  • dependencies.yaml
  • python/libcudf/pyproject.toml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Enhancements
    • Added runtime support for locating CUDA installations automatically.
    • Included CUDA path discovery in the project’s runtime dependency configuration.

Walkthrough

The dependency configuration adds the run_libcudf group and includes it in py_run_libcudf. The libcudf project metadata adds cuda-pathfinder to runtime dependencies.

Changes

libcudf runtime dependency declaration

Layer / File(s) Summary
Declare and wire cuda-pathfinder
dependencies.yaml, python/libcudf/pyproject.toml
The run_libcudf group provides cuda-pathfinder, py_run_libcudf includes the group, and libcudf declares the package as a runtime dependency.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to d440d

This PR explicitly declares an existing runtime dependency for libcudf wheels. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: msarahan, bdice, vyasr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: declaring the cuda-pathfinder dependency for libcudf wheels.
Description check ✅ Passed The description directly explains why libcudf wheels need cuda-pathfinder and identifies the related follow-up and issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr

vyasr commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

I'm going to admin merge. The single CI failure is unrelated to this change and it is being fixed in #23883. No need to rerun CI here just for that.

@vyasr
vyasr merged commit c5cbf0b into NVIDIA:main Aug 29, 2026
146 of 157 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Aug 29, 2026
@jameslamb
jameslamb deleted the pathfinder-dep branch August 31, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants