Skip to content

Fix FastIntDiv tparam #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjnolet merged 2 commits into from
Jun 29, 2026
Merged

Fix FastIntDiv tparam #2278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb7ea30
fix-FastIntDiv-tparam
aamijar Jun 29, 2026
312dfdb
Merge branch 'main' into fix-FastIntDiv-tparam
aamijar Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cpp/tests/neighbors/ann_ivf_flat.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.

@cjnolet cjnolet Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this adding "& Affiliates"?

@aamijar aamijar Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is because of 627f2d7. And because of this rapidsai/pre-commit-hooks#120.

* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand Down Expand Up @@ -329,11 +329,13 @@ class AnnIVFFlatTest : public ::testing::TestWithParam<AnnIvfFlatInputs<IdxT>> {
[dim = idx.dim(),
list_size,
padded_list_size,
chunk_size = raft::util::FastIntDiv(idx.veclen())] __device__(auto i) {
chunk_size = raft::util::FastIntDiv<int32_t>(
static_cast<int32_t>(idx.veclen()))] __device__(auto i) {
uint32_t max_group_offset = interleaved_group::roundDown(list_size);
if (i < max_group_offset * dim) { return true; }
uint32_t surplus = (i - max_group_offset * dim);
uint32_t ingroup_id = interleaved_group::mod(surplus / chunk_size);
uint32_t surplus = (i - max_group_offset * dim);
uint32_t ingroup_id =
interleaved_group::mod(static_cast<int32_t>(surplus) / chunk_size);
return ingroup_id < (list_size - max_group_offset);
});

Expand Down
Loading