validate vGPU capability record lengths - #1994
Open
kvalliyurnatt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Karthikeyan Valliyurnatt <kvalliyurnat@nvidia.com>
kvalliyurnatt
requested review from
cdesiniotis,
henry118,
karthikvetrivel,
rahulait,
rajatchopra,
rajathagasthya and
tariq1890
and removed request for
rajatchopra
August 31, 2026 22:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes vGPU capability parsing so malformed PCI records cannot cause GPU Feature Discovery to hang or read outside the capability buffer.
Details
A nonterminal vGPU capability record with a zero-length field caused Device.GetInfo() to repeatedly process the same record, resulting in an infinite loop and 100% CPU usage.
This change:
Uses an int cursor to prevent uint8 wraparound.
Requires nonterminal records to include at least their two-byte header.
Validates record boundaries before reading or advancing.
Validates the host-driver record and payload length.
Adds tests for zero-length, truncated, undersized, oversized, and valid records.