Skip to content

fix(dell): match DPU HTTP boot option by name prefix, not exact equality #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirson-git wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(dell): match DPU HTTP boot option by name prefix, not exact equality #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/dell.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ impl Redfish for Bmc {
let (expected, actual) = self
.get_expected_and_actual_first_boot_option(crate::BootInterfaceRef::Mac(mac))
.await?;
if expected.is_none() || expected != actual {
if !matches!((&expected, &actual), (Some(e), Some(a)) if a.starts_with(e)) {
diffs.push(MachineSetupDiff {
key: "boot_first".to_string(),
expected: expected.unwrap_or_else(|| "Not found".to_string()),
Expand Down Expand Up @@ -1146,7 +1146,7 @@ impl Redfish for Bmc {
.await?;
let boot_order = self.get_boot_order().await?;
for (idx, boot_option) in boot_order.iter().enumerate() {
if boot_option.display_name == expected_boot_option_name {
if boot_option.display_name.starts_with(&expected_boot_option_name) {
if idx == 0 {
// Dells will not generate a bios config job below if the boot orders already configured correctly
tracing::info!(
Expand Down Expand Up @@ -1358,7 +1358,7 @@ impl Redfish for Bmc {
let (expected, actual) = self
.get_expected_and_actual_first_boot_option(boot_interface)
.await?;
Ok(expected.is_some() && expected == actual)
Ok(matches!((&expected, &actual), (Some(e), Some(a)) if a.starts_with(e)))
})
}

Expand Down