GIN: implement reset-without-zeroing for signals and counters#2155
Open
bhasunit wants to merge 1 commit intoNVIDIA:v2.30u1from
Open
GIN: implement reset-without-zeroing for signals and counters#2155bhasunit wants to merge 1 commit intoNVIDIA:v2.30u1from
bhasunit wants to merge 1 commit intoNVIDIA:v2.30u1from
Conversation
Replace signal/counter reset-by-zeroing with an offset-based scheme. Instead of writing zero to the underlying atomic, resetSignal and resetCounter snapshot the current value into a per-context offset array. Subsequent reads and waits subtract the offset, making the signal/counter appear reset without modifying the NIC-visible value. Signed-off-by: Sunita Bhaskaran <bhasunit@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace signal/counter reset-by-zeroing in GIN with an offset-based scheme.
Instead of writing zero to the underlying atomic, resetSignal and
resetCounter snapshot the current value into a per-context offset
array. Subsequent reads and waits subtract the offset, making the
signal/counter appear reset without modifying the NIC-visible value.
Related Issues
Original PR against 2.30 #2093
Changes & Impact
None
Performance Impact
Improved performance on p5en with GIN.