fix(cloud-functions): reject floating-point request priorities - #1302
fix(cloud-functions): reject floating-point request priorities#1302cr7258 wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe PR adds strict integer deserialization for LLM priority values, tests rejected fractional updates, and changes the fork PR CodeQL workflow to upload all SARIF result files. ChangesInteger Validation
CodeQL Artifacts
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change rejects fractional request priorities instead of silently coercing them and keeps existing configuration unchanged when updates are invalid; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Reject floating-point JSON values for integer request-priority fields instead of silently coercing values such as
1.5to1.Key Changes
defaultPriorityandperAccountPriorityupdates.CI Fix
The CodeQL analysis succeeded, but the fork-only artifact step expected
results/java-kotlin.sarifwhile the CodeQL action generatedresults/java.sarif. The upload path now accepts the SARIF file generated by the current matrix job.Observed failure:
Failed CodeQL job
Summary by CodeRabbit
Bug Fixes
Tests