test(bdd): propagate trace context in watch probes - #1333
Conversation
Signed-off-by: Mike Camp <mcamp@nvidia.com>
Relates to #1307 Signed-off-by: Mike Camp <mcamp@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Independent review of current head Both outbound Watch probes now carry distinct, valid W3C version-00 The focused wiring test, full short BDD suite, Go vet, shell checks, DCO, targeted sensitive-string checks, and diff hygiene are green. The before/after Mermaid diagrams are also verified. CodeRabbit skipped review because this PR targets a stacked, non-default base. #1333 is ready for stacked integration into #1310; #1310 still requires its current- |
9beff1a to
9d0f64c
Compare
TL;DR
Propagate valid W3C Trace Context metadata on both secure multi-region
WatchStargatesprobes and keep the exact-command wiring coverage synchronized.Additional Details
CodeRabbit identified that the Region B
grpcurlprobe in #1310 omittedtraceparentmetadata. The adjacent Region A probe is also an outbound gRPC call, so this companion applies the repository trace-propagation convention consistently to both calls.Each probe uses a distinct, valid W3C
traceparentvalue. The feature behavior, TLS authority, certificate trust, and response assertions are unchanged.This Pull Request is stacked on #1310 and targets its feature branch.
Before
After
For the Reviewer
Please verify the two
grpcurl -Hadditions and their byte-for-byte wiring expectations intests/bdd/godog_test.go.Original review thread: #1310 (comment)
For QA
Validated in an isolated development environment:
go test -short -count=1 ./...go vet ./...git diff --checkThe configured full lint command still reports two pre-existing staticcheck capitalization findings in
tests/bdd/dsl/manifests.go; this companion does not modify that file. A live cluster run was not performed for this review-only change.Issues
Relates to #1307
Dependencies
No new or updated third-party dependencies. No license or NOTICE changes are required.
Checklist